Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter remedies in prohibitions #4092

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Apr 5, 2024

What this PR changes/adds

#4056 added remedy to Prohibition but the ScopeFilter part was missing

Why it does that

policy evaluation

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Part of #3959

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added enhancement New feature or request policy labels Apr 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.69%. Comparing base (7f20ba5) to head (fc9d026).
Report is 202 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4092      +/-   ##
==========================================
+ Coverage   71.74%   74.69%   +2.94%     
==========================================
  Files         919      979      +60     
  Lines       18457    20074    +1617     
  Branches     1037     1128      +91     
==========================================
+ Hits        13242    14994    +1752     
+ Misses       4756     4589     -167     
- Partials      459      491      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 9df78b8 into eclipse-edc:main Apr 9, 2024
16 checks passed
@ndr-brt ndr-brt deleted the 3959-filter-remedies branch April 9, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants