Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: constructor arg and type hierarchy #4173

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Fixes the type hierarchy of the DataIntegrityKeyPair

Why it does that

  • wrong type hierarchy leads to failing checks
  • wrong constructor argument leads to NPE

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4170

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the bug Something isn't working label May 13, 2024
@paullatzelsperger paullatzelsperger merged commit a6a17f5 into eclipse-edc:main May 13, 2024
18 checks passed
@paullatzelsperger paullatzelsperger deleted the fix/constructor_and_correct_itf branch May 13, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EDC 0.6.3+ DataIntegrityKeyPair implements wrong interface.
2 participants