Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add architecture document for Management Domains #4263

Merged
merged 7 commits into from
Jun 17, 2024

Conversation

jimmarino
Copy link
Contributor

What this PR changes/adds

Adds an architecture document for Management Domains.

Why it does that

Briefly state why the change was necessary.

Further notes

One or more DRs will be added later.

Linked Issue(s)

Related to #4262

@jimmarino jimmarino added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 11, 2024
Copy link
Contributor

@mspiekermann mspiekermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I have nothing against the content (quite the opposite), I would move section 3 out of this specific document. I think it would be better to split the explanation of the management-domain concept and how it is implemented (which is better placed in a story, issues and/or a decision record).

@jimmarino
Copy link
Contributor Author

While I have nothing against the content (quite the opposite), I would move section 3 out of this specific document. I think it would be better to split the explanation of the management-domain concept and how it is implemented (which is better placed in a story, issues and/or a decision record).

Yes, more implementation specifics will be added in subsequent DRs. This was just intended as an outline of what needs to be done. I think I mentioned that in the associated issue.

@jimmarino jimmarino merged commit bacdf5a into eclipse-edc:main Jun 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants