Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test to presenationquery transformer #4324

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Adds two test cases to the JsonObjectToPresentationQueryTransformer, testing an empty array and a null array for the scope parameter

Why it does that

test coverage

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Contributes #4322

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Jul 3, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.21%. Comparing base (7f20ba5) to head (20c2c62).
Report is 336 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4324      +/-   ##
==========================================
+ Coverage   71.74%   75.21%   +3.46%     
==========================================
  Files         919     1053     +134     
  Lines       18457    21135    +2678     
  Branches     1037     1184     +147     
==========================================
+ Hits        13242    15896    +2654     
+ Misses       4756     4722      -34     
- Partials      459      517      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit 7808392 into eclipse-edc:main Jul 3, 2024
24 of 26 checks passed
@paullatzelsperger paullatzelsperger deleted the chore/add_tests_to_presentationquery_transformer branch July 3, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants