Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: BigQuery data plane description #182

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

man8pr
Copy link
Contributor

@man8pr man8pr commented Jun 19, 2024

What this PR changes/adds

Added description of the first implementation for BQ data plane.

@man8pr man8pr added the documentation Improvements or additions to documentation label Jun 19, 2024
Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use this as a starting point, but I think the concept of streaming query results as pages is not 100% where it should be.

Further comments inline.


## Data source

The data source supports queries with [named parameters](https://cloud.google.com/bigquery/docs/parameterized-queries). To set the values of the named parameters, the `BigQueryRequestParams` generated by `BigQueryRequestParamsProvider.provideSourceParams` (invoked from `BigQueryDataSourceFactory.createSource`) includes also the sink address passed when the transfer process is started by the consumer. The sink address must provide the values of the parameters in the query in the form:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data source supports queries with named parameters

mentioning that they are analogous to SQL query parameters may let people understand it even better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update the doc, thanks!

docs/developer/bigquery/bq-data-plane.md Show resolved Hide resolved
docs/developer/bigquery/bq-data-plane.md Show resolved Hide resolved
docs/developer/bigquery/bq-data-plane.md Show resolved Hide resolved
@man8pr
Copy link
Contributor Author

man8pr commented Jun 26, 2024

We can use this as a starting point, but I think the concept of streaming query results as pages is not 100% where it should be.

Further comments inline.

Agree, the concept of multi part should more about parallelizing, this is an optimization that can be taken over once the functionality is overall confirmed.

@man8pr man8pr changed the title docs: BigQuery data plan description docs: BigQuery data plane description Jun 27, 2024
@paullatzelsperger paullatzelsperger merged commit 5fc8297 into eclipse-edc:main Jun 27, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants