Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix equals on incomparable types #1308

Merged
merged 1 commit into from Sep 17, 2021
Merged

fix equals on incomparable types #1308

merged 1 commit into from Sep 17, 2021

Conversation

lukasj
Copy link
Member

@lukasj lukasj commented Sep 17, 2021

Signed-off-by: Lukas Jungmann lukas.jungmann@oracle.com

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2021

This pull request fixes 43 alerts when merging ed27ee3 into 335f958 - view on LGTM.com

fixed alerts:

  • 38 for Equals on incomparable types
  • 4 for Hashed value without hashCode definition
  • 1 for Inconsistent equals and hashCode

@lukasj lukasj merged commit 1547f59 into eclipse-ee4j:master Sep 17, 2021
@lukasj lukasj deleted the eq branch September 17, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants