Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code cleanup - reduntant method calls #1310

Merged
merged 1 commit into from Sep 17, 2021
Merged

code cleanup - reduntant method calls #1310

merged 1 commit into from Sep 17, 2021

Conversation

lukasj
Copy link
Member

@lukasj lukasj commented Sep 17, 2021

Signed-off-by: Lukas Jungmann lukas.jungmann@oracle.com

rfelcman
rfelcman approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2021

This pull request introduces 1 alert and fixes 20 when merging fc4e0c0 into 1547f59 - view on LGTM.com

new alerts:

  • 1 for Inconsistent equals and hashCode

fixed alerts:

  • 15 for Misleading indentation
  • 2 for Dereferenced variable may be null
  • 2 for Implicit narrowing conversion in compound assignment
  • 1 for Equals method does not inspect argument type

@lukasj
code cleanup - reduntant method calls
60008b7 
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj lukasj merged commit 771945f into eclipse-ee4j:master Sep 17, 2021
@lukasj lukasj deleted the eq2 branch September 17, 2021 19:36
@lgtm-com
Copy link

lgtm-com bot commented Sep 17, 2021

This pull request fixes 20 alerts when merging 60008b7 into 1547f59 - view on LGTM.com

fixed alerts:

  • 15 for Misleading indentation
  • 2 for Dereferenced variable may be null
  • 2 for Implicit narrowing conversion in compound assignment
  • 1 for Equals method does not inspect argument type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfelcman rfelcman rfelcman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukasj @rfelcman