Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 6.x to master #23843

Merged
merged 40 commits into from
Mar 18, 2022
Merged

Merge 6.x to master #23843

merged 40 commits into from
Mar 18, 2022

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Mar 4, 2022

No description provided.

glassfish-bot and others added 30 commits February 12, 2022 17:19
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
- still used j2ee.jar
- mixed tabs and spaces
- removed dead tests
- dead tests - mejb or JAX-RPC dependency
- wsdl variable can be null
- reproduced by some test enabled in recent commits
- fixes issue reproducible by some of naming_all tests when using
  cluster instances
- respects some externally set env properties
- removes glassfish before execution
- detects glassfish version automatically
- bug was reproducible by several tests from recent commits
- removed endorsed as it is not supported any more
…everal bugs

- reproducible by several tests enabled in recent commits
- removed incorrect wrapping of zip into zip
- fixed error message, reported input file as an output
- fixed closing streams
- fixed removing corrupted files (stream could be still open)
- fixed behavior when the glassfish-acc.xml file is missing
- lazy init, but then crashed
- MEJB is not supported any more, see specification of Jakarta EE 9.1
Enhanced runtests.sh and reenabled another block of tests
@dmatej dmatej self-assigned this Mar 4, 2022
@dmatej
Copy link
Contributor Author

dmatej commented Mar 9, 2022

Blocked by this: eclipse-ee4j/metro-wsit#161

@arjantijms
Copy link
Contributor

@dmatej

Blocked by this: eclipse-ee4j/metro-wsit#161

Since that one has now been unblocked (thanks to you and @lukasj), can we now proceed with this PR?

@dmatej
Copy link
Contributor Author

dmatej commented Mar 13, 2022

Goood! Can we have 4.0.0-M4? Or do I have to add another snapshot build?

@arjantijms
Copy link
Contributor

@lukasj I can stage a 4.0.0-M4 too for Metro (WSIT, or WebServices) if needed.

@lukasj
Copy link
Member

lukasj commented Mar 14, 2022

M4 is planned to be in the last week of March to accommodate changes from dependencies/subprojects. My hope is that grizzly (which I've already asked for back in Jan) will be ready by then and M4 will be the last milestone before the final release. Not sure it was observed that main metro parts (jaxb/jax-ws-ri/wsit) do have M builds on a ~monthly basis and the version number is synced through these projects to make it easier to track changes. I'd like to keep this pattern.

@arjantijms
Copy link
Contributor

My hope is that grizzly (which I've already asked for back in Jan)

If I'm not mistaken @dmatej is working on that as we speak ;) Not every part of it appeared to be trivial, but process is being made.

I'd like to keep this pattern.

It's sometimes difficult to keep patterns when you're part of a larger project. If everyone would stick to a monthly pattern, then it would take more than 2 years (27 months), give or take, until we could release GF 7.

@lukasj
Copy link
Member

lukasj commented Mar 15, 2022

Where does the "larger project" have its rough schedule, so those being included there can plan their work as needed? Is the whole work supposed to be "one-man show" or collaborative effort?

@dmatej
Copy link
Contributor Author

dmatej commented Mar 15, 2022

My hope is that grizzly (which I've already asked for back in Jan) will be ready by then

I am working on that today, I was without electricity yesterday.

Is the whole work supposed to be "one-man show" or collaborative effort?

I would see it as some event-driven automat with multiple actors, where every actor works (or asks for help) on anything he requires for an actual project. Schedules are rather orientation points then.

@arjantijms
Copy link
Contributor

Where does the "larger project" have its rough schedule

The rough schedule is the Jakarta EE 10 release plan (https://eclipse-ee4j.github.io/jakartaee-platform/jakartaee10/JakartaEE10ReleasePlan) and specifically for GlassFish there's the tracking board here: https://github.com/eclipse-ee4j/glassfish/projects/3

With so many projects it is indeed mostly event driven. We have about 10 contributors for the 7 release https://github.com/eclipse-ee4j/glassfish/graphs/contributors?from=2021-11-03&to=2022-03-15&type=c although some are helping by preparing dependencies in their own repos (like Scott for Hibernate Validate) and don't show up directly in that graph.

@lukasj
Copy link
Member

lukasj commented Mar 15, 2022

that project board show no dates as does the release plan. It says nothing about estimated target dates for GF RCs/final builds, it also says nothing about GF weekly(?)/milestone builds. It really does not help to align releases of component CIs with GF release - at least those I'm somehow responsible for and I can help with (~11 top-level projects from > 30repos).

Events as such are fine and should definitely be responded to, yet some time-buffer should be expected.

btw: I did not say you can't do some metro-4.0.0-gf1 (or whatever keeps treating current M3 as the latest) build if you really need it a week ago ;-)

- fixed which maven uses which settings.xml
- invoker builds with the custom settings.xml
- invoker builds projects in parallel threads
- fixed relativePath
- added properties to settings.xml - skip everything not required
- servlet6
- grizzly 4 snapshot
- webservices 4 snapshot

Signed-off-by: David Matějček <dmatej@seznam.cz>
@dmatej
Copy link
Contributor Author

dmatej commented Mar 18, 2022

So, current status + dependency tree:

@arjantijms arjantijms merged commit 6287b63 into eclipse-ee4j:master Mar 18, 2022
@dmatej dmatej deleted the merge-to-master branch March 19, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants