Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented #2153 - Upgraded to Servlet 6 #2156

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Implemented #2153 - Upgraded to Servlet 6 #2156

merged 1 commit into from
Mar 16, 2022

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Mar 16, 2022

Signed-off-by: David Matějček dmatej@seznam.cz

@dmatej
Implemented eclipse-ee4j#2153 - Upgraded to Servlet 6
a461b6e 
Signed-off-by: David Matějček <dmatej@seznam.cz>
@dmatej
Copy link
Contributor Author

dmatej commented Mar 16, 2022

Local build passed including tests

@pzygielo
Copy link
Contributor

Could the JDK used in https://ci.eclipse.org/grizzly/job/Grizzly-master_nightly/ be updated, please?

@dmatej
Copy link
Contributor Author

dmatej commented Mar 16, 2022

Could the JDK used in https://ci.eclipse.org/grizzly/job/Grizzly-master_nightly/ be updated, please?

I don't have rights to do that, seems at least switching from JDK8 to JDK11 would be nice ... @arjantijms ?

@arjantijms
Copy link
Contributor

I'm on it, thanks!

@arjantijms
Copy link
Contributor

Update done!

@arjantijms arjantijms merged commit a933a6b into eclipse-ee4j:master Mar 16, 2022
@arjantijms arjantijms added this to the 4.0 milestone Mar 16, 2022
@dmatej dmatej deleted the servlet6 branch March 16, 2022 13:36
@pzygielo
Copy link
Contributor

thanks! and of course - staging profile has to be activated -
https://ci.eclipse.org/grizzly/job/Grizzly-master_nightly/1518/consoleText:

Executing Maven:  -B -f /home/jenkins/agent/workspace/Grizzly-master_nightly/pom.xml clean install -Dmaven.test.redirectTestOutputToFile=true -DforkCount=1 -DreuseForks=false -Denforcer.skip=true
...
[ERROR] Failed to execute goal on project grizzly-http-servlet: Could not resolve dependencies for project org.glassfish.grizzly:grizzly-http-servlet:bundle:4.0.0-SNAPSHOT: Could not find artifact jakarta.servlet:jakarta.servlet-api:jar:6.0.0 in eclipse.maven.central.mirror (https://repo.eclipse.org/content/repositories/maven_central/) -> [Help 1]

This was referenced Mar 17, 2022
Closed
Merged
hs536
hs536 reviewed Jun 8, 2022
View reviewed changes
modules/http-servlet/src/main/java/org/glassfish/grizzly/servlet/SessionCookieConfig.java
private boolean httpOnly = true;
private boolean secure;
private static final int DEFAULT_MAX_AGE = -1;
private static final boolean DEFAULT_HTTP_ONLY = false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmatej could you tell me the reason for changing this default value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, but I don't know after 3 months, perhaps I should make a comment in the commit. It seems to me as a mistake now.

@dmatej dmatej mentioned this pull request Jun 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hs536 hs536 hs536 left review comments

@arjantijms arjantijms arjantijms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dmatej @pzygielo @arjantijms @hs536