Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate missing config when asadmin set is called (2nd attempt) #24185

Merged

Conversation

OndroMih
Copy link
Contributor

Fixes #24158. Automatically creates missing config nodes in the set command, if they aren't present in domain.xml.

Added tests to cover multiple scenarios:

  • setting an attribute directly (this test was already present)
  • setting an attribute through an alias (a different dotted name leading to the same config node)
  • seting a custom property a=b
  • setting an attribute on a node which isn't in the current configuration and which will be created before setting the attribute (this is the new feature implemented)

This is a fix of #24160, which was reverted by #24170 to pass the tests.

Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
…perty

Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
A new node should be defined and attribute set on it.
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
@OndroMih OndroMih force-pushed the ondro-generate-missing-config-set branch from b376c36 to 75443de Compare November 19, 2022 03:41
Clean up of the unit test.
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
@arjantijms arjantijms merged commit a800ae8 into eclipse-ee4j:master Nov 23, 2022
@OndroMih OndroMih deleted the ondro-generate-missing-config-set branch January 14, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asadmin set command fails if the parent config object isn't already present
4 participants