Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asadmin set command fails if the parent config object isn't already present #24158

Closed
OndroMih opened this issue Nov 11, 2022 · 0 comments · Fixed by #24185
Closed

Asadmin set command fails if the parent config object isn't already present #24158

OndroMih opened this issue Nov 11, 2022 · 0 comments · Fixed by #24185

Comments

@OndroMih
Copy link
Contributor

Environment Details

  • GlassFish 7.0.0-M9
  • JDK version: Zulu17.36+13-CA (build 17.0.4+8-LTS)
  • OS: Ubuntu 22.04.1 LTS
  • Database: N/A

Problem Description

When running asadmin set command to set a dotted configuration and the parent dotted configuration doesn't exist, the set command fails to set the configuration.

Steps to reproduce

On a fresh GlassFish installation, run:

 bin/asadmin set configs.config.server-config.network-config.protocols.protocol.http-listener-1.ssl.cert-nickname=s1as

This will fail with the following output:

remote failure: No configuration found for configs.config.server-config.network-config.protocols.protocol.http-listener-1.ssl
Command set failed.

This is because the default domain.xml file doesn't contain any ssl element for the http-listener-1 protocol. It works for the http-listener-2 protocol, which contains the ssl element.

A similar error can be reproduced in Admin Console if GlassFish is built from these branches: #23782 (comment). When editing the SSL tab of the http-listener-1, pressing the Save button leads to the same error and there's no way to fix this in the Admin Console.

Impact of Issue

//: When editing the SSL configuration of the HTTP listener, it's not possible to save the configuration in Admin Console.

Type:Enhancement
Component: Kernel, Admin, Admin Console

OndroMih added a commit to OndroMih/glassfish that referenced this issue Nov 11, 2022
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
arjantijms added a commit to arjantijms/glassfish that referenced this issue Nov 13, 2022
…n nodes Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>"

This reverts commit f2ac9c1.
arjantijms added a commit that referenced this issue Nov 13, 2022
Revert "#24158 - Asadmin set creates missing configuration nodes
OndroMih added a commit to OndroMih/glassfish that referenced this issue Nov 19, 2022
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
OndroMih added a commit to OndroMih/glassfish that referenced this issue Nov 19, 2022
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
OndroMih added a commit to OndroMih/glassfish that referenced this issue Nov 19, 2022
…perty

Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
OndroMih added a commit to OndroMih/glassfish that referenced this issue Nov 19, 2022
A new node should be defined and attribute set on it.
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
OndroMih added a commit to OndroMih/glassfish that referenced this issue Nov 19, 2022
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
OndroMih added a commit to OndroMih/glassfish that referenced this issue Nov 19, 2022
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
OndroMih added a commit to OndroMih/glassfish that referenced this issue Nov 19, 2022
…perty

Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
OndroMih added a commit to OndroMih/glassfish that referenced this issue Nov 19, 2022
A new node should be defined and attribute set on it.
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
OndroMih added a commit to OndroMih/glassfish that referenced this issue Nov 19, 2022
Clean up of the unit test.
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant