Fixing builds on Windows #24606

dmatej · 2023-09-25T17:48:17Z

I would not recommend MS Windows for a development to anyone, however ... I would like to see the build passing at least basically. Also tests are useful to see differences between operating systems and can suggest some solutions of possible issues.

avpinchuk · 2023-09-25T20:00:37Z

To save your time, part 1:

glassfish/nucleus/admin/launcher/src/test/java/com/sun/enterprise/admin/launcher/GFLauncherTest.java

Line 94 in 67d5fae

    
           assertThat(cmdline, hasItems(endsWith("java"), is("-cp"), is("-XX:+UnlockDiagnosticVMOptions"), is("-verbose")));

glassfish/nucleus/admin/launcher/src/test/java/com/sun/enterprise/admin/launcher/GFLauncherTest.java

Line 106 in 67d5fae

    
           hasItems(endsWith("java"), is("-cp"), not(is("-XX:+UnlockDiagnosticVMOptions")), is("-verbose")));

endsWith("java") works on UNIX but failed on Windows due to java.exe.

Also we should disable with @DisabledOnOs(OS.WINDOWS) for whole test class:

glassfish/appserver/libpam4j/src/test/java/org/jvnet/libpam/UnixUserTest.java

Line 26 in 67d5fae

public class UnixUserTest {

Asterisk * improperly quoted on Windows and asadmin get * command fails:

glassfish/appserver/itest-tools/src/test/java/org/glassfish/main/admin/test/tool/StartStopITest.java

Line 39 in 67d5fae

assertThat(ASADMIN.exec("get", "*"), asadminOK());

dmatej · 2023-09-25T22:39:28Z

To save your time, part 1:

glassfish/nucleus/admin/launcher/src/test/java/com/sun/enterprise/admin/launcher/GFLauncherTest.java

Line 94 in 67d5fae

assertThat(cmdline, hasItems(endsWith("java"), is("-cp"), is("-XX:+UnlockDiagnosticVMOptions"), is("-verbose")));

glassfish/nucleus/admin/launcher/src/test/java/com/sun/enterprise/admin/launcher/GFLauncherTest.java

Line 106 in 67d5fae

hasItems(endsWith("java"), is("-cp"), not(is("-XX:+UnlockDiagnosticVMOptions")), is("-verbose")));

endsWith("java") works on UNIX but failed on Windows due to java.exe.

Also we should disable with @DisabledOnOs(OS.WINDOWS) for whole test class:

glassfish/appserver/libpam4j/src/test/java/org/jvnet/libpam/UnixUserTest.java

Line 26 in 67d5fae

public class UnixUserTest {

Asterisk * improperly quoted on Windows and asadmin get * command fails:

glassfish/appserver/itest-tools/src/test/java/org/glassfish/main/admin/test/tool/StartStopITest.java

Line 39 in 67d5fae

assertThat(ASADMIN.exec("get", "*"), asadminOK());

Bit late, I already did that, but at least we have same ideas :-)
I ended with this exception in server.log, which is probably caused by some security software not under my control. So I will just push what I have for now ...

[2023-09-25T21:52:29.061483+02:00] [GF 7.0.9-SNAPSHOT] [WARNING] [NCLS-JMX-00007] [jakarta.enterprise.system.jmx] [tid: _ThreadID=82 _ThreadName=Thread-9] [levelValue: 900] [[
  Cannot start JMX connector JmxConnector config: { name = system, Protocol = rmi_jrmp, Address = 0.0.0.0, Port = 8686, AcceptAll = false, AuthRealmName = admin-realm, SecurityEnabled = false} due to exception java.io.IOException: Cannot bind to URL [rmi://xxxxx:8686/jmxrmi]: javax.naming.ServiceUnavailableException [Root exception is java.rmi.ConnectException: Connection refused to host:xxxxx; nested exception is: 
	java.net.ConnectException: Connection timed out: connect]]]

I cannot make the host name public, but it is from some managed windows domain and I have no rights to expose port on this machine.

avpinchuk · 2023-09-25T23:11:24Z

appserver/itest-tools/src/test/java/org/glassfish/main/admin/test/tool/StartStopITest.java

@@ -36,6 +36,6 @@ class StartStopITest {
     */
    @Test
    void asadminGet() {
-        assertThat(ASADMIN.exec("get", "*"), asadminOK());
+        assertThat(ASADMIN.exec("get", "'*'"), asadminOK());


On Windows work with double quotes, on Linux - no. We need some condition here.

Aha, I thought it passed on my Windows, but this test failed to start the domain (unable to expose ports). Can you finish the PR? I can't do more on this machine. I just used the opportunity to try it :)

avpinchuk · 2023-09-27T18:14:50Z

This PR #24610 should fix OSGICommandsITest on Windows.

dmatej · 2023-09-28T21:58:40Z

Aha, I did not notice you switched it back to Draft, @avpinchuk

avpinchuk · 2023-09-28T22:47:21Z

Yes. This is because we need to close several bugs in GF, not only in tests ;)

dmatej · 2023-09-29T07:19:57Z

Yes. This is because we need to close several bugs in GF, not only in tests ;)

Ok, I will leave it on your decision for now, thank you.

avpinchuk · 2023-09-30T19:15:53Z

Patch #24611 fixes resource disposition on Windows platform. Now it works:

glassfish/appserver/tests/embedded/basic/lifecycle/src/test/java/org/glassfish/tests/embedded/basic/lifecycle/LifeCycleTest.java

Line 87 in 95e7c0f

private void checkDisposed() {

avpinchuk · 2023-10-01T17:42:45Z

On Windows, Files.copy(src, dst, attrs) set actual creationTime and lastAcccessTime for dst, but copy lastModifiedTime from src.

Thus, JspReloadGeneratedServletIfUpdatedTest failed because JspReloadGeneratedServletIfUpdated_jsp compiled at build time and has earlier lastModifiedTime than generated by JSP engine. When we copying build-time version instead of generated, its modified timestamp left unchanged.

avpinchuk · 2023-10-01T17:48:36Z

Windows 10 Pro 22H2 (19045.3448):

mvn clean install -Pstaging

avpinchuk · 2023-10-01T17:49:05Z

@dmatej, all done.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- Unix feature Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>

dmatej · 2023-10-02T19:32:15Z

I have yet one failure, the exec plugin execution (and same previous gfbuild-maven-plugin:exec) were depending on OS java command, same as #24617 , I will fix it now.

- if it executed asadmin, it used OS default java Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

avpinchuk · 2023-10-02T19:57:05Z

I opened yet another PR to WaSP eclipse-ee4j/wasp#61

avpinchuk · 2023-10-02T20:15:27Z

I started the build... BUILD SUCCESS

dmatej · 2023-10-03T12:16:23Z

I started the build... BUILD SUCCESS

So, let's make it Ready for review, do you agree?

avpinchuk · 2023-10-03T12:25:04Z

So, let's make it Ready for review, do you agree?

Yes, sure.

arjantijms · 2023-10-03T14:05:01Z

LGTM, although I didn't test on Windows. The WaSP PR has some good comments btw ;)

avpinchuk · 2023-10-03T16:25:17Z

The WaSP PR has some good comments btw ;)

I pushed a fixed version

dmatej self-assigned this Sep 25, 2023

dmatej added bug Something isn't working build and test improvement labels Sep 25, 2023

dmatej force-pushed the windows branch from c0eb36e to a9a21af Compare September 25, 2023 22:42

dmatej marked this pull request as ready for review September 25, 2023 22:42

dmatej requested review from gerdogdu, arjantijms, jGauravGupta, hs536, Tomas-Kraus and avpinchuk September 25, 2023 22:45

dmatej added this to the 7.0.9 milestone Sep 25, 2023

avpinchuk reviewed Sep 25, 2023

View reviewed changes

arjantijms modified the milestones: 7.0.9, 7.0.10 Sep 26, 2023

avpinchuk marked this pull request as draft September 26, 2023 21:24

dmatej marked this pull request as ready for review September 28, 2023 21:57

dmatej marked this pull request as draft September 28, 2023 21:58

dmatej assigned avpinchuk and unassigned dmatej Sep 28, 2023

dmatej force-pushed the windows branch from fc8bd9a to 03d5f50 Compare September 30, 2023 17:14

dmatej and others added 10 commits October 2, 2023 21:29

Fixed CRLF issues on windows os

b102d59

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

Fixed File locking tests for windows

a4bc9d4

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

Using annotations to run test just on compatible OS

a9ecc22

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

GFLauncherTest fixed for Windows

a5c93bb

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

The libpam tests disabled on windows

1ed7ec5

- Unix feature Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

Fixed StartupITest - failed on windows with firewall

82a0c88

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

Fixed StartStopITest - Windows vs. * asterisk

63de5d7

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

Fixed StartStopITest - Windows vs. * asterisk - attempt2

31d4f67

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

Fix possible NumberFormatException

9e1ed14

Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>

Fix updated JSP reload test

ec9caa8

Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>

Fixed AS_JAVA and JAVA_HOME env properties for exec-maven-plugin

b233fbc

- if it executed asadmin, it used OS default java Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

dmatej force-pushed the windows branch from dbaf566 to b233fbc Compare October 2, 2023 19:56

dmatej marked this pull request as ready for review October 3, 2023 13:57

arjantijms approved these changes Oct 3, 2023

View reviewed changes

avpinchuk approved these changes Oct 3, 2023

View reviewed changes

dmatej merged commit 6c70a06 into eclipse-ee4j:master Oct 3, 2023
2 checks passed

dmatej deleted the windows branch October 3, 2023 23:04

dmatej mentioned this pull request Oct 5, 2023

ManagedFile is platform dependent #24622

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing builds on Windows #24606

Fixing builds on Windows #24606

dmatej commented Sep 25, 2023

avpinchuk commented Sep 25, 2023

dmatej commented Sep 25, 2023

avpinchuk Sep 25, 2023

dmatej Sep 25, 2023

avpinchuk Sep 26, 2023

avpinchuk commented Sep 27, 2023

dmatej commented Sep 28, 2023

avpinchuk commented Sep 28, 2023

dmatej commented Sep 29, 2023

avpinchuk commented Sep 30, 2023

avpinchuk commented Oct 1, 2023

avpinchuk commented Oct 1, 2023

avpinchuk commented Oct 1, 2023

dmatej commented Oct 2, 2023

avpinchuk commented Oct 2, 2023

avpinchuk commented Oct 2, 2023 •

edited

dmatej commented Oct 3, 2023

avpinchuk commented Oct 3, 2023

arjantijms commented Oct 3, 2023

avpinchuk commented Oct 3, 2023

Fixing builds on Windows #24606

Fixing builds on Windows #24606

Conversation

dmatej commented Sep 25, 2023

avpinchuk commented Sep 25, 2023

dmatej commented Sep 25, 2023

avpinchuk Sep 25, 2023

Choose a reason for hiding this comment

dmatej Sep 25, 2023

Choose a reason for hiding this comment

avpinchuk Sep 26, 2023

Choose a reason for hiding this comment

avpinchuk commented Sep 27, 2023

dmatej commented Sep 28, 2023

avpinchuk commented Sep 28, 2023

dmatej commented Sep 29, 2023

avpinchuk commented Sep 30, 2023

avpinchuk commented Oct 1, 2023

avpinchuk commented Oct 1, 2023

avpinchuk commented Oct 1, 2023

dmatej commented Oct 2, 2023

avpinchuk commented Oct 2, 2023

avpinchuk commented Oct 2, 2023 • edited

dmatej commented Oct 3, 2023

avpinchuk commented Oct 3, 2023

arjantijms commented Oct 3, 2023

avpinchuk commented Oct 3, 2023

avpinchuk commented Oct 2, 2023 •

edited