Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GlassFish process runtime type detection #24611

Merged
merged 3 commits into from
Sep 30, 2023

Conversation

avpinchuk
Copy link
Contributor

@avpinchuk avpinchuk commented Sep 28, 2023

Detects EMBEDDED instance at runtime.

This fixes all resources cleanup at shutdown.

@avpinchuk avpinchuk added the bug Something isn't working label Sep 28, 2023
@avpinchuk avpinchuk added this to the 7.0.10 milestone Sep 28, 2023
@avpinchuk avpinchuk self-assigned this Sep 28, 2023
@avpinchuk avpinchuk marked this pull request as draft September 28, 2023 21:27
@dmatej
Copy link
Contributor

dmatej commented Sep 28, 2023

Hmm, I have a perhaps one year old branch with fixes of resource leaks, time to push that. Not sure if this was in between, probably not, but I know I have also new bugs in that, that's why it is still waiting ... however I am not sure how many conflicts I have to resolve, I didn't rebase it few versions ...

Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
@avpinchuk avpinchuk changed the title Close RAR classloaders during servers shutdown Improve Embedded GlassFish runtime type detection Sep 30, 2023
@avpinchuk avpinchuk changed the title Improve Embedded GlassFish runtime type detection Improve GlassFish process runtime type detection Sep 30, 2023
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
@avpinchuk avpinchuk marked this pull request as ready for review September 30, 2023 17:32
@dmatej dmatej merged commit 95e7c0f into eclipse-ee4j:master Sep 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants