Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CClassInfoConstructor #1452

Merged

Conversation

dschulten
Copy link
Contributor

closes #1114

Use lastIndexOf to construct the correct parent and shortName from fullname.

…llName

Signed-off-by: Dietrich Schulten <ds@escalon.de>
@dschulten dschulten force-pushed the 1114-cclassinfo-constructor-fullname branch from 7b9a025 to 56baba5 Compare May 24, 2020 13:59
@dschulten
Copy link
Contributor Author

This should also be backported to 2.3.x, but I am unsure how to proceed. Should I create a PR against the 2.3.2-RI-RELEASE branch?

@lukasj
Copy link
Member

lukasj commented May 25, 2020

There is no branch for 2.x and no plan for that yet. At least not till 3.0 gets out.

Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants