Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Maven plugin docs for JAXB 3 #1508

Merged
merged 1 commit into from
May 18, 2022
Merged

Conversation

adamretter
Copy link
Contributor

Closes #1506

We spent some time to add JAXB 3 support to the two most popular Maven plugins. The existing plugins that were in the documentation only support JAXB 2.2. At the moment these two plugins to the best of our knowledge (Maven Central) are the only plugins that support JAXB 3.

@adamretter
Copy link
Contributor Author

@lukasj As requested.

<plugins>
<plugin>
<groupId>com.evolvedbinary.maven.jvnet</groupId>
<artifactId>jaxb-maven-plugin</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks wrong, shouldn't this part be about org.jvnet.jaxb2.maven2:maven-jaxb2-plugin instead?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think the evolvedbinary project changed the name of the original jvnet plugin to leave out jaxb version and to call it a maven-plugin rather than a jaxb2-plugin.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am now the primary maintainer of the org.jvnet.jab2.maven2 plugin. Sadly, the original author and maintainer (Aleksei aka highsource) passed away. I just released a version for 2.x and am preparing the changes to include JAXB 3.x support.

Please do not remove the reference to Aleksei's plugin from the documentation. It is used by a ton of projects and still gets a ton of daily traffic to the GH page.

ref: https://github.com/highsource/maven-jaxb2-plugin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for heads up @mattrpav, I'm going to put that back in the next PR.

@lukasj
Copy link
Member

lukasj commented Feb 17, 2021

@adamretter eca check failed, likely due to missing sign-off in the commit . Can you try to git commit -s --amend followed by git push -f?

Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit f31e7b4 into eclipse-ee4j:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants