-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Maven plugin docs for JAXB 3 #1508
Conversation
@lukasj As requested. |
<plugins> | ||
<plugin> | ||
<groupId>com.evolvedbinary.maven.jvnet</groupId> | ||
<artifactId>jaxb-maven-plugin</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks wrong, shouldn't this part be about org.jvnet.jaxb2.maven2:maven-jaxb2-plugin
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It think the evolvedbinary project changed the name of the original jvnet plugin to leave out jaxb version and to call it a maven-plugin
rather than a jaxb2-plugin
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am now the primary maintainer of the org.jvnet.jab2.maven2 plugin. Sadly, the original author and maintainer (Aleksei aka highsource) passed away. I just released a version for 2.x and am preparing the changes to include JAXB 3.x support.
Please do not remove the reference to Aleksei's plugin from the documentation. It is used by a ton of projects and still gets a ton of daily traffic to the GH page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for heads up @mattrpav, I'm going to put that back in the next PR.
@adamretter eca check failed, likely due to missing sign-off in the commit . Can you try to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #1506