Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dtd parsing #1702

Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix dtd parsing #1702

merged 1 commit into from
Mar 31, 2023

Conversation

antoniosanct
Copy link
Contributor

Hi, everyone!

Fighting with a big DTD file I found a bug parsing null references. I wish you can integrate this PR.

The DTD afected is:
https://publication-bdds.apps.epo.org/bdds/bdds-bff-service/prod/api/public/products/19/delivery/472/item/1284/download

Regards,
Antonio.

Signed-off-by: Antonio Santos Izaguirre <antoniosanct@gmail.com>
@antoniosanct
Copy link
Contributor Author

Another option is transform Block elements attribute from LinkedHashSet to LinkedList to allow duplicated elements, and always generate a default class when element is #PCDATA, at Element clasClass() method. In this way, avoids NPE and JAXB runs correctly.
Regards,
Antonio.

@antoniosanct
Copy link
Contributor Author

Any updates about this?
Thanks a lot! Regards,
Antonio.

Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit 0b9b53a into eclipse-ee4j:master Mar 31, 2023
@lukasj
Copy link
Member

lukasj commented Mar 31, 2023

thanks!

@lukasj lukasj linked an issue May 19, 2023 that may be closed by this pull request
@antoniosanct antoniosanct deleted the master_fixdtd branch June 9, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nullpointer Exception in DTD parsing
2 participants