Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xjc): call postProcessModel with DTD models #1727

Merged

Conversation

nros
Copy link
Contributor

@nros nros commented Aug 2, 2023

When code is generated from DTD schema, the hook function postProcessModel was not called. The code to do so was moved from global utility class to BGMBuilder class in the old code more than five years ago with the effect, that the hook was not called anymore for any other input than XSD.

A Junit 4 test is included.

  • Eclipse account is created with same name as commiter email addres
  • ECA is signed

When code is generated from DTD schema, the hook function
`postProcessModel` was not called. The code to do so was moved
from global utility class to `BGMBuilder` class in the old code more
than five years ago with the effect, that the hook was not called
anymore for any other input than XSD.

A Junit 4 test is included.

Signed-off-by: Nikolaus Rosenmayr <nr@firecoder.com>
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lukasj lukasj merged commit 1116d50 into eclipse-ee4j:master Sep 5, 2023
1 check passed
@lukasj lukasj linked an issue Sep 5, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xjc: postProcessModel is not called for DTDs
2 participants