Fixing GH-737 : compute class type with generics handle #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasj
reviewed
Feb 9, 2024
There was a problem hiding this comment.
Can you add notes to the changelog, please? Link both issue being fixed there..
Also update the copyright year to 2024 in all files being modified in this PR.
Thanks!
laurentschoelens
force-pushed
the
gh-737
branch
from
02b5def
to
b19a9f7
Compare
|
@lukasj : forced push this PR with wanted changes 😉 |
lukasj
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #737
Fixes #209 (to check if it was dependant of #737)
Add generic handle in xjc:javaType
The
nametag should be of the form :name="java.util.List<java.lang.String>"for expectedList<String>Need also to provide good
adapterthat implements the wantedXmlAdapter<String, ExpectedType>whereExpectedTypewith the example would beList<String>like CommaDelimitedStringAdapter