fix some compile-time warnings

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
eclipse-ee4j · Mar 12, 2022 · 61e61dd · 61e61dd
1 parent 7dd45b5
commit 61e61dd
Show file tree

Hide file tree

Showing 95 changed files with 234 additions and 288 deletions.
diff --git a/wsit/bundles/pom.xml b/wsit/bundles/pom.xml
@@ -27,6 +27,9 @@
 
     <properties>
         <spotbugs.skip>true</spotbugs.skip>
+        <comp.xlint>-Xlint:none</comp.xlint>
+        <comp.xdoclint>-Xdoclint:none</comp.xdoclint>
+        <jdoc.doclint>none</jdoc.doclint>
     </properties>
 
     <modules>

diff --git a/wsit/bundles/webservices-extra-xmlsec/pom.xml b/wsit/bundles/webservices-extra-xmlsec/pom.xml
@@ -285,5 +285,8 @@
         <dep.sources>${project.build.directory}/generated-sources/dependencies</dep.sources>
         <dep.sources.mr>${project.build.directory}/generated-sources/dependencies-mr</dep.sources.mr>
         <dep.sources.jaxb>${project.build.directory}/generated-sources/dependencies-jaxb</dep.sources.jaxb>
+        <comp.xlint>-Xlint:none</comp.xlint>
+        <comp.xdoclint>-Xdoclint:none</comp.xdoclint>
+        <jdoc.doclint>none</jdoc.doclint>
     </properties>
 </project>
diff --git a/...nfig/metro-config-impl/src/main/java/com/sun/xml/ws/policy/parser/PolicyConfigParser.java b/...nfig/metro-config-impl/src/main/java/com/sun/xml/ws/policy/parser/PolicyConfigParser.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1997, 2021 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2022 Oracle and/or its affiliates. All rights reserved.
  *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Distribution License v. 1.0, which is available at
@@ -229,7 +229,6 @@ public static WSDLModel parseModel(final URL configFileUrl, final boolean isClie
      * {@code null} is returned as a result of this method call. In case
      * of any other problems that may occur while locating the WSIT config file, a
      * {@link PolicyException} is thrown.
-     * <p>
      *
      * @param configFileIdentifier base of WSIT config file name (web service name for WSIT service
      *        config file or "client" for WSIT client configuration). Must not be {@code null}.

diff --git a/...time/metro-runtime-impl/src/test/java/com/sun/xml/ws/assembler/MetroConfigLoaderTest.java b/...time/metro-runtime-impl/src/test/java/com/sun/xml/ws/assembler/MetroConfigLoaderTest.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1997, 2021 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2022 Oracle and/or its affiliates. All rights reserved.
  *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Distribution License v. 1.0, which is available at
@@ -21,7 +21,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class MetroConfigLoaderTest extends TestCase {
 

diff --git a/wsit/pom.xml b/wsit/pom.xml
@@ -722,10 +722,10 @@
             -Djava.awt.headless=true -Xmx256m
         </argLine>
         <!-- exclude big groups from the Xlint -->
-        <comp.xlint>-Xlint:all,-rawtypes,-unchecked,-serial</comp.xlint>
+        <comp.xlint>-Xlint:all,-rawtypes,-unchecked</comp.xlint>
         <!-- -Xdoclint:-missing does not seem to work properly on the infra -->
-        <comp.xdoclint>-Xdoclint:none</comp.xdoclint>
-        <warn.limit>150</warn.limit>
+        <comp.xdoclint>-Xdoclint:all,-missing</comp.xdoclint>
+        <warn.limit>150000</warn.limit>
         <jdoc.doclint>all,-missing</jdoc.doclint>
     </properties>
 

diff --git a/wsit/samples/audiostream/AudioStreamPlayer/src/player/Main.java b/wsit/samples/audiostream/AudioStreamPlayer/src/player/Main.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1997, 2018 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2022 Oracle and/or its affiliates. All rights reserved.
  *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Distribution License v. 1.0, which is available at
@@ -17,7 +17,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class Main {
 

diff --git a/wsit/samples/audiostream/AudioStreamerApp/src/java/provider/AudioStreamer.java b/wsit/samples/audiostream/AudioStreamerApp/src/java/provider/AudioStreamer.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1997, 2020 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2022 Oracle and/or its affiliates. All rights reserved.
  *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Distribution License v. 1.0, which is available at
@@ -19,7 +19,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 @WebService
 public class AudioStreamer {

diff --git a/wsit/samples/audiostream/AudioStreamerApp/web/index.jsp b/wsit/samples/audiostream/AudioStreamerApp/web/index.jsp
@@ -1,6 +1,6 @@
 <%--
 
-    Copyright (c) 1997, 2018 Oracle and/or its affiliates. All rights reserved.
+    Copyright (c) 1997, 2022 Oracle and/or its affiliates. All rights reserved.
 
     This program and the accompanying materials are made available under the
     terms of the Eclipse Distribution License v. 1.0, which is available at
@@ -12,7 +12,7 @@
 
 <%-- 
     Document   : index
-    Author     : Marek Potociar <marek.potociar at sun.com>
+    Author     : Marek Potociar
 --%>
 
 <%@page contentType="text/html" pageEncoding="UTF-8"%>

diff --git a/...a/com/sun/xml/ws/transport/tcp/connectioncache/spi/transport/OutboundConnectionCache.java b/...a/com/sun/xml/ws/transport/tcp/connectioncache/spi/transport/OutboundConnectionCache.java
@@ -84,7 +84,7 @@ public interface OutboundConnectionCache<C extends Connection>
      * that return connections in LRU order, with the least recently used
      * connection first.  This is done to aid a finder that wishes to consider
      * load balancing in its determination of an appropriate connection.
-     * <P>
+     *
      */
     C get( ContactInfo<C> cinfo, ConnectionFinder<C> finder
     ) throws IOException ;

diff --git a/...tcp/soaptcp-impl/src/main/java/com/sun/xml/ws/transport/tcp/io/ByteBufferInputStream.java b/...tcp/soaptcp-impl/src/main/java/com/sun/xml/ws/transport/tcp/io/ByteBufferInputStream.java
@@ -19,7 +19,7 @@
 public class ByteBufferInputStream extends InputStream {
 
     /**
-     * The wrapped <code>ByteBuffer</code<
+     * The wrapped <code>ByteBuffer</code>
      */
     private ByteBuffer byteBuffer;
 

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_0/invm/ackrequestedinterval/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_0/invm/ackrequestedinterval/client/ClientTest.java
@@ -17,7 +17,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
     private static final Logger LOGGER = Logger.getLogger(ClientTest.class.getName());

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_0/invm/basicorderedoneway/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_0/invm/basicorderedoneway/client/ClientTest.java
@@ -24,7 +24,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
 

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_0/invm/dispatch/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_0/invm/dispatch/client/ClientTest.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1997, 2020 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2022 Oracle and/or its affiliates. All rights reserved.
  *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Distribution License v. 1.0, which is available at
@@ -33,7 +33,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
 

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_0/invm/jcapsnack/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_0/invm/jcapsnack/client/ClientTest.java
@@ -17,7 +17,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
     private static final Logger LOGGER = Logger.getLogger(ClientTest.class.getName());

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_0/invm/oneway/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_0/invm/oneway/client/ClientTest.java
@@ -17,7 +17,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
     private static final Logger LOGGER = Logger.getLogger(ClientTest.class.getName());

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_0/invm/secureonewaysoap12/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_0/invm/secureonewaysoap12/client/ClientTest.java
@@ -17,7 +17,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
     private static final Logger LOGGER = Logger.getLogger(ClientTest.class.getName());

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_0/persistent/ackrequestedinterval/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_0/persistent/ackrequestedinterval/client/ClientTest.java
@@ -17,7 +17,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
     private static final Logger LOGGER = Logger.getLogger(ClientTest.class.getName());

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_0/persistent/basicorderedoneway/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_0/persistent/basicorderedoneway/client/ClientTest.java
@@ -24,7 +24,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
 

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_0/persistent/dispatch/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_0/persistent/dispatch/client/ClientTest.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1997, 2020 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2022 Oracle and/or its affiliates. All rights reserved.
  *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Distribution License v. 1.0, which is available at
@@ -33,7 +33,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
 

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_0/persistent/jcapsnack/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_0/persistent/jcapsnack/client/ClientTest.java
@@ -17,7 +17,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
     private static final Logger LOGGER = Logger.getLogger(ClientTest.class.getName());

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_0/persistent/oneway/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_0/persistent/oneway/client/ClientTest.java
@@ -17,7 +17,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
     private static final Logger LOGGER = Logger.getLogger(ClientTest.class.getName());

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_0/persistent/secureonewaysoap12/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_0/persistent/secureonewaysoap12/client/ClientTest.java
@@ -17,7 +17,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
     private static final Logger LOGGER = Logger.getLogger(ClientTest.class.getName());

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_1/invm/ackrequestedinterval/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_1/invm/ackrequestedinterval/client/ClientTest.java
@@ -17,7 +17,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
     private static final Logger LOGGER = Logger.getLogger(ClientTest.class.getName());

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_1/invm/basicorderedoneway/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_1/invm/basicorderedoneway/client/ClientTest.java
@@ -24,7 +24,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
 

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_1/invm/dynamic_endpoint_address/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_1/invm/dynamic_endpoint_address/client/ClientTest.java
@@ -19,7 +19,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
     private static final Logger LOGGER = Logger.getLogger(ClientTest.class.getName());

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_1/invm/jcapsnack/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_1/invm/jcapsnack/client/ClientTest.java
@@ -17,7 +17,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
     private static final Logger LOGGER = Logger.getLogger(ClientTest.class.getName());

diff --git a/wsit/tests/e2e/testcases/wsrm/v1_1/invm/oneway/client/ClientTest.java b/wsit/tests/e2e/testcases/wsrm/v1_1/invm/oneway/client/ClientTest.java
@@ -17,7 +17,7 @@
 
 /**
  *
- * @author Marek Potociar <marek.potociar at sun.com>
+ * @author Marek Potociar
  */
 public class ClientTest extends TestCase {
     private static final Logger LOGGER = Logger.getLogger(ClientTest.class.getName());

diff --git a/wsit/ws-mex/src/main/java/com/sun/xml/ws/mex/client/MetadataClient.java b/wsit/ws-mex/src/main/java/com/sun/xml/ws/mex/client/MetadataClient.java
@@ -23,6 +23,7 @@
 import jakarta.xml.bind.Unmarshaller;
 import javax.xml.namespace.QName;
 import javax.xml.stream.XMLInputFactory;
+import javax.xml.stream.XMLStreamConstants;
 import javax.xml.stream.XMLStreamException;
 import javax.xml.stream.XMLStreamReader;
 
@@ -212,7 +213,7 @@ private Metadata createMetadata(final InputStream stream)
         int state = 0;
         do {
             state = reader.next();
-        } while (state != reader.START_ELEMENT ||
+        } while (state != XMLStreamConstants.START_ELEMENT ||
             !reader.getLocalName().equals("Metadata"));
 
         final Unmarshaller uMarhaller = jaxbContext.createUnmarshaller();

diff --git a/...java/com/sun/xml/ws/security/addressing/impl/policy/AddressingPolicyAssertionCreator.java b/...java/com/sun/xml/ws/security/addressing/impl/policy/AddressingPolicyAssertionCreator.java
@@ -19,7 +19,6 @@
 import com.sun.xml.ws.policy.spi.AssertionCreationException;
 import com.sun.xml.ws.policy.spi.PolicyAssertionCreator;
 import java.lang.reflect.Constructor;
-import java.lang.reflect.InvocationTargetException;
 import java.util.Collection;
 import java.util.HashSet;
 import java.util.logging.Level;
@@ -91,37 +90,16 @@ public PolicyAssertion createAssertion(AssertionData assertionData, Collection<P
             if(cons != null){
                 try {
                     return (PolicyAssertion) cons.newInstance(assertionData, nestedAssertions, nestedAlternative);
-                } catch (IllegalArgumentException ex) {
-                    if(LOGGER.isLoggable(Level.SEVERE)){
-                        LOGGER.log(Level.SEVERE,LocalizationMessages.WSA_0003_ERROR_INSTANTIATING(assertionData.getName()));
-                    }
-
-                    throw new AssertionCreationException(assertionData,ex);
-                } catch (InvocationTargetException ex) {
-                    if(LOGGER.isLoggable(Level.SEVERE)){
-                        LOGGER.log(Level.SEVERE,LocalizationMessages.WSA_0003_ERROR_INSTANTIATING(assertionData.getName()));
-                    }
-                    throw new AssertionCreationException(assertionData,ex);
-                } catch (InstantiationException ex) {
-                    if(LOGGER.isLoggable(Level.SEVERE)){
-                        LOGGER.log(Level.SEVERE,LocalizationMessages.WSA_0003_ERROR_INSTANTIATING(assertionData.getName()));
-                    }
-                    throw new AssertionCreationException(assertionData,ex);
-                } catch (IllegalAccessException ex) {
-                    if(LOGGER.isLoggable(Level.SEVERE)){
+                } catch (ReflectiveOperationException ex) {
+                    if(LOGGER.isLoggable(Level.SEVERE)) {
                         LOGGER.log(Level.SEVERE,LocalizationMessages.WSA_0003_ERROR_INSTANTIATING(assertionData.getName()));
                     }
                     throw new AssertionCreationException(assertionData,ex);
                 }
             }else{
                 try{
-                    return (PolicyAssertion)cl.newInstance();
-                } catch (InstantiationException ex) {
-                    if(LOGGER.isLoggable(Level.SEVERE)){
-                        LOGGER.log(Level.SEVERE,LocalizationMessages.WSA_0003_ERROR_INSTANTIATING(assertionData.getName()));
-                    }
-                    throw new AssertionCreationException(assertionData,ex);
-                } catch (IllegalAccessException ex) {
+                    return (PolicyAssertion)cl.getConstructor().newInstance();
+                } catch (ReflectiveOperationException ex) {
                     if(LOGGER.isLoggable(Level.SEVERE)){
                         LOGGER.log(Level.SEVERE,LocalizationMessages.WSA_0003_ERROR_INSTANTIATING(assertionData.getName()));
                     }

diff --git a/wsit/ws-sx/wssx-impl/src/main/java/com/sun/xml/ws/security/impl/DerivedKeyTokenImpl.java b/wsit/ws-sx/wssx-impl/src/main/java/com/sun/xml/ws/security/impl/DerivedKeyTokenImpl.java
@@ -31,7 +31,7 @@ public class DerivedKeyTokenImpl implements DerivedKeyToken {
     private long length = 32; // Default length
     private long offset = 0; // Default offset
     private long generation = 0;
-    private String label = this.DEFAULT_DERIVEDKEYTOKEN_LABEL;
+    private String label = DerivedKeyToken.DEFAULT_DERIVEDKEYTOKEN_LABEL;
     private byte[] secret, nonce;
 
     /** Creates a new instance of DerivedKeyTokenImpl */
@@ -82,7 +82,7 @@ public DerivedKeyTokenImpl(long generation, byte[] secret){
     @Override
     public URI getAlgorithm() {
         try {
-            return new URI(this.DEFAULT_DERIVED_KEY_TOKEN_ALGORITHM);
+            return new URI(DerivedKeyToken.DEFAULT_DERIVED_KEY_TOKEN_ALGORITHM);
         } catch (URISyntaxException ex) {
             //ignore
         }
@@ -101,7 +101,7 @@ public long getOffset() {
 
     @Override
     public String getType() {
-        return this.DERIVED_KEY_TOKEN_TYPE;
+        return DerivedKeyToken.DERIVED_KEY_TOKEN_TYPE;
     }
 
     @Override