Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the code compile on Java 10+ #4461

Closed
ggam opened this issue Sep 18, 2018 · 4 comments
Closed

Make the code compile on Java 10+ #4461

ggam opened this issue Sep 18, 2018 · 4 comments

Comments

@ggam
Copy link
Member

ggam commented Sep 18, 2018

At the moment the project doesn't compile with Java 10. Since the build system is still being cleaned up, drastically simplifying it, this is a reminder that at some point this task will need to be accomplished.

@arjantijms
Copy link
Contributor

By the time we'll get to this, it's probably going to be JDK 11.

@ggam
Copy link
Member Author

ggam commented Sep 18, 2018

Yes, we are in a hurry if we want to make this before Java 11 http://www.java-countdown.xyz/
But hopefully fixing it for Java 10 will still work on the next versions.

@ggam
Copy link
Member Author

ggam commented Sep 18, 2018

Interestingly, Java 11 goes beyond 10 compiling Mojarra. With Java 10 I was getting a "static import only from classes and interfaces" error that might actually be a JDK bug, but with 11 that's gone and the first fail is compiling a test with error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:2.10:ear (default-ear) on project correctScanningEar: Execution default-ear of goal org.apache.maven.plugins:maven-ear-plugin:2.10:ear failed: An API incompatibility was encountered while executing org.apache.maven.plugins:maven-ear-plugin:2.10:ear: java.lang.ExceptionInInitializerError: null

Maybe updating Maven dependencies does the trick.

@ggam ggam changed the title Make the code compile on Java 10 Make the code compile on Java 10+ Sep 18, 2018
lasombra pushed a commit to lasombra/mojarra that referenced this issue Oct 25, 2018
lasombra added a commit to lasombra/mojarra that referenced this issue Oct 25, 2018
@lasombra
Copy link
Contributor

I got it working locally with this PR. Hope it's enough to close this issue. :)

lasombra added a commit to lasombra/mojarra that referenced this issue Oct 25, 2018
lasombra added a commit to lasombra/mojarra that referenced this issue Oct 25, 2018
This should fix issue eclipse-ee4j#4461

Signed-off-by: Ingo Hoffmann <ingo@hoffmann.cx>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants