Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Artifact ID to all output #189

Open
angayap opened this issue Mar 8, 2023 · 6 comments
Open

Apply Artifact ID to all output #189

angayap opened this issue Mar 8, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request low-priority Low priority issue

Comments

@angayap
Copy link

angayap commented Mar 8, 2023

Hello,
can we point to
in file
archetype\src\main\resources\archetype-resources\pom.xml
line 53 <name>${artifactId}</name>

line 1153 <finalName>${artifactId}</finalName>

Tank

@m-reza-rahman
Copy link
Contributor

Do you feel this is a high priority? If so, please issue a PR including fixes to the Dockerfile and all documentation. If not, we can get to this when we are able. It's not particularly difficult, but it is a lot of work and I am not sure it's that big a deal.

@m-reza-rahman m-reza-rahman added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed low-priority Low priority issue labels Mar 9, 2023
@ojuschugh1
Copy link

sir we have to only change name and filename in all pom.xml file in src ?

@m-reza-rahman
Copy link
Contributor

As I already mentioned, it's far more than that. The generated Dockerfile and all associated documentation, including generated READMEs will need to be handled. If someone wants to work on this I suggest first adequately understanding the project. Most likely that will take days if not weeks for a newcomer. This is no easy task.

@ojuschugh1
Copy link

ojuschugh1 commented Mar 25, 2023

ohh that's why i was thinking it seems so easy i just right now commited it lol :(

@m-reza-rahman m-reza-rahman changed the title Change <filename> and <name> to point to ${artifactId} Apply Artifact ID to all output Oct 6, 2023
@m-reza-rahman m-reza-rahman removed good first issue Good for newcomers help wanted Extra attention is needed labels Oct 6, 2023
@geziefer
Copy link
Contributor

I could do this one together with #274

@geziefer
Copy link
Contributor

Was addressed in PR #291
All files now respect the given artifactId, including pom, readme, docker, war
Java package is left unchanged for now, it contains groupId + fix sub package (-> see mailing list discussion, may be changed in different PR)

m-reza-rahman added a commit that referenced this issue May 15, 2024
Use artifactId in archetype (#189, partly #274)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority Low priority issue
Projects
None yet
Development

No branches or pull requests

4 participants