Use artifactId in archetype (#189, partly #274) #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
This was referenced Dec 31, 2023
|
Is this ready for serious review yet or should I wait a bit more? |
|
@m-reza-rahman Yes, it should be. This part was reworked according to our discussion about using artifactId allover the place when generating. As also discussed, I only excluded the Java packaging, which stays fix. But other than that, the given ids should be used everywhere. I tested it together with the UI PR and also from command line and it looked good to me for different scenarios. |
|
Hi @geziefer, can I kindly ask you to resolve the merge conflicts? I'll then get this merged and released. |
|
@m-reza-rahman: README file should be ok now, the rest seems fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR concentrates on the archetype and uses artifactId in all generated files.
It was tested, that the pom contains the reight coordinates, the war file is named correctly, the readme contains the right app name, the docker file is named like that and works and a deployment in WildFly is working.
The archetype was both used from command line and from UI (-> see separate PR).
Unchanged was the package of Java files (-> see discussion on mailing list, I can adapt this in a separate ticket/PR once we agree on how to do it)