Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Origin header with https:// schema for secure requests #783

Merged
merged 1 commit into from May 10, 2022

Conversation

rpuch
Copy link
Contributor

@rpuch rpuch commented Apr 29, 2022

Otherwise, Origin validation fails for such requests

Signed-off-by: Roman Puchkovskiy roman.puchkovskiy@gmail.com

Otherwise, Origin validation fails for such requests

Signed-off-by: Roman Puchkovskiy <roman.puchkovskiy@gmail.com>
@jansupol
Copy link
Contributor

jansupol commented May 5, 2022

I am +1 for the change but need to file a CQ for spring-boot (only a committer can do so)

@rpuch
Copy link
Contributor Author

rpuch commented May 6, 2022

Hi @jansupol. Thanks for your reply. Do I need to do anything to help get the CQ filed, or should I just patiently wait?

Also, I have a stupid question. What is CQ? :)

@jansupol
Copy link
Contributor

jansupol commented May 6, 2022

I have created a Wiki describing CQs.

Unfortunately, there is nothing you can do regarding CQs at the moment.

@rpuch
Copy link
Contributor Author

rpuch commented May 6, 2022

Thank you for the page, I learned something new today

@arjantijms
Copy link
Contributor

I have created a Wiki describing CQs.

I still find the process very, very painful. Perhaps we should bundle some resources to create a plug-in that checks for this automatically, and, with an option, also files the CQs if needed in a semi-automated way.

@jansupol
Copy link
Contributor

I still find the process very, very painful.

I agree. There is another issue with the CQ. The CQ might not get approved before the Release Review and the IP log would not be approved before the release review process, in that case. There is currently a discussion about the IP policy in the Foundation, perhaps there will be some changes. Let's see what the news is.

Let's merge this, exclude the test for the release, and put it back once the release review is done.

@jansupol jansupol merged commit a370f22 into eclipse-ee4j:master May 10, 2022
@jansupol jansupol added this to the 1.19 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants