Turn JsonbComponentInstanceCreator into a service provider interface

[mkouba]

So that an integrator could provide a custom implementation of this interface. JsonbComponentInstanceCreatorFactory currently contains some reflection magic to detect the presence of a CDI container. In fact, the presence of the CDI API is enough.

I believe it would be reasonable to define this SPI. Quarkus integration would definitely make use of it because our DI solution is compatible with CDI but we don't support all "portable extensions related" SPIs (they do not fit into our build time metadata processing approach) and so the invocation of the BeanManagerInstanceCreator#getOrCreateComponent() fails.

[gsmet]

Any thought on this? This is rather blocking for the Yasson Quarkus integration and we have quite a few users asking for it.

[aguibert]

Can you elaborate on what needs to happen in order to turn this into an SPI? Are you asking that we make a META-INF/service/ entry for this? Or perhaps just moving it out of the Yasson .internal package so it is exported by our JPMS module?

[mkouba]

Just use the ServiceLoader to obtain the JsonbComponentInstanceCreator instance so that an integrator could provide its own implementation. The logic from JsonbComponentInstanceCreatorFactory should be extracted to a default impl (e.g. DefaultJsonbComponentInstanceCreator) and either moved to a separate artifact with META-INF/service config, or alternatively JsonbComponentInstanceCreator could define a priority (e.g. default int getPriority() { return 1; }) and the instance with the highest priority is used.

[aguibert]

Sounds like a reasonable change -- do you have cycles to propose a PR?

[mkouba]

Yes, I'll try to prepare something.

[geoand]

I can work on this next week when I am back if you haven't had time to do it until the @mkouba

…

On Tue, Apr 30, 2019, 08:52 Martin Kouba ***@***.***> wrote: Yes, I'll try to prepare something. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#260 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBMDP4C6NJXITTYZE7RSWTPS7UEVANCNFSM4HFPOECA> .

[gsmet]

@bravehorsie @aguibert is the next release already scheduled? Asking that so that we don't miss it and do the appropriate work in Quarkus as soon as it is released.

Thanks!

[bravehorsie]

@gsmet @aguibert Lets review current PRs and do the release.

[masini]

Thank you for fixing this issue, is a blocking one for our porting to JSONB.

[gsmet]

@bravehorsie @aguibert any news on the release front?

Thanks!

[aguibert]

@bravehorsie I added a code review to #262 (your big JSON-P interop PR) and I think we should merge it and then we should be good to cut a new release.

[bravehorsie]

Yasson 1.0.4 has been released to central, which includes the fix.

[gsmet]

Thanks @bravehorsie !