Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MappingContext.java #327

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Refactor MappingContext.java #327

merged 1 commit into from
Sep 5, 2019

Conversation

Degubi
Copy link
Contributor

@Degubi Degubi commented Sep 4, 2019

  • Refactor ParseClassModelFunction into a static factory that creates Function<Class<?>, ClassModel> (named as createParseClassModelFunction). Removes an inner interface.
  • Remove classModelIterator, not used anywhere. Removes an inner class.
  • Use the return value of 'classes.computeIfAbsent' instead of calling 'computeIfAbsent' and then 'get' after it, saves using 'get'.
  • Add '<?>'-s, avoids some warnings.
  • No changes in behavior, just to remove some bloat.

Signed-off-by: Gyúróczki Gergő gergonoorbi@gmail.com

Signed-off-by: Gyúróczki Gergő <gergonoorbi@gmail.com>
Copy link
Member

@aguibert aguibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aguibert aguibert merged commit 1dd96ea into eclipse-ee4j:master Sep 5, 2019
@Degubi Degubi deleted the mappingctx_refactor branch September 5, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants