-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move equinox.server.p2 into p2 repository #42
Move equinox.server.p2 into p2 repository #42
Conversation
Fails with:
We probably have to wait for a quiet day (or at least after an I-build?) or have to force this into the repo? |
What is this |
I honestly never understood how that feature got used "for real". IIRC it was an attempt to allow p2 to be used to manage an installation based inside of a WAR that embeds the equinox platform. Perhaps something we should announce for removal. |
If there is no real use case I'm also in favor to remove it. For now I thought more about the failure cause and it looks like this is a general problem because with the suggested move (but the same applies for the suggested simplification in PR #40): I think this could only be solved in Tycho if the resolution of the feature content is also delayed to the time the feature is build and the final build-qualifier of the plug-in is therefore known? |
This is expected behavior if you use "include" (either feature or bundle) as it resolves to the current build content and thus is resolved at build time. |
Please remove it, in the past I tried to make sense out of it and failed. In the past we had this, if you don't know that this is for, lets not touch it mentality in the project but of course it is better to get rid of stuff we don't know that it is for than to keep dragging its weight along. If it is important for someone this person will speak up after removal and we can restore. |
I couldn't figure out what it does either.... |
That makes all of us not making any sense of it. IMHO it should be asked at equinox-dev for concrete example how someone uses it and remove after no one provides such. |
Alright, I created a draft for the removal and announced it on the mailing list: |
This is the removal part of the move.
12bd6ee
to
5a68c7c
Compare
Should we close this issue as we agreed to simply remove this code? |
No, I think we should continue with this. We agreed to remove |
Ack |
The |
In #40 (comment) it was discussed to move the o.e.equinox.server.p2 feature into the p2 repository since it mainly consists of p2 plug-ins and therefore should reside in the same repository.
This the removal part of the move. The feature is added to p2 in eclipse-equinox/p2#62.