Make the URLStreamHandler as lazy as possible #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URLStreamHandlerFactoryImpl currently opens a service tracker unconditionally for URLStreamHandlerService to discover registered handlers. This leads to any handler being fetched eagerly instead of when it is required. This changes the handling in a way where it is as lazy as possible by - not open a tracker until a protocol is requested - use a service tracker with a specific protocol filter in proxy - only fetch the service when it is first used
|
@tjwatson if we can agree on the change I'd like to include this in 2023-09-M2 |
This was referenced Jul 5, 2023
tjwatson
reviewed
Jul 6, 2023
...rg.eclipse.osgi/container/src/org/eclipse/osgi/internal/url/URLStreamHandlerFactoryImpl.java
Show resolved
Hide resolved
tjwatson
approved these changes
Jul 7, 2023
|
Then lets see how this works out 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLStreamHandlerFactoryImpl currently opens a service tracker unconditionally for URLStreamHandlerService to discover registered handlers. This leads to any handler being fetched eagerly instead of when it is required.
This changes the handling in a way where it is as lazy as possible by