Register the maven protocol handler as a DS component #1465
Conversation
|
This currently references if that is fixed, we should switch back to using |
laeubi
force-pushed
the
migrate_streamhandler_to_ds
branch
2 times, most recently
from
b632cef
to
1f06487
Compare
|
@mickaelistria in commit 0fc9523 you reverted registering this with ECF do you remember what was the problem back there? |
laeubi
force-pushed
the
migrate_streamhandler_to_ds
branch
from
1f06487
to
084a3e2
Compare
|
@laeubi yes, it was failing because there was a circular dependency at exec between ECF (loading m2e extension) and m2e (loading ECF) and this was causing failures to startup m2e. But with DS, since the service are more lazily resolved, it could be fine. |
|
I have tried searching the code but can't find that m2e is using ECF anywhere do you have a pointer where the dependency to ECF originates? |
|
The dependency was probably originating from the addition of the protocol handler itself. I don't remember the details, but I remember that I thought that something lazier could probably solve it. |
|
Alright, I'll maybe try to debug this, actually the extension registry should also allow to use it lazy so maybe something to improve for ECF... |
|
@mickaelistria I have now debugged this a bit and it seems all ECF does is actually register the extension point as a service, so this seems redundant here them, but it could be more lazy anyways I'll open a PR. |
|
I have now created |
|
I also discovered one problem with ECF and custom handlers, created |
FYI @merks this will make the protocol available as soon as possible even if m2e is currently not activated by other means.