-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#406 Update to Theia 1.18.0 and switch to Codicons #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great!
I've just seen two minor issues when tested in combination with the Theia integration (which I've upgraded locally for now). I believe they may be caused by this change in glsp-client even though they only show up in combination with glsp-theia-integration.
- When right-clicking a task and select
Direct Edit Task
and then selectduration:
and then replace the0
with anything that's not a number, an error appears. In this error decoration, the icon is now missing. - The forkOrJoin nodes should be black by default and in Theia's light-mode and light gray in dark mode (similar or same as edges in dark mode).
To reproduce, you just need to run yarn upgrade:next
in glsp-theia-integration
.
Thank you for your review Philip! |
Thanks that's fixed now if I also checkout eclipse-glsp/glsp-theia-integration#98 |
- Upgrade sprotty version - Replace FontAwesome icons with codicons - Adapt issue marker svgs to match codicons - Adapt workflow example styling - Update documentation GIF - Add mocha option to ignore style imports (@font-face) Fixes eclipse-glsp/glsp/issues/406
Thanks for catching that! As mentioned in the other PR, the reason for that was a missing import of the the css file in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for your work!
Dependes on eclipse-glsp/glsp-server#134
Part of eclipse-glsp/glsp/issues/406