Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#406 Update to Theia 1.18.0 and switch to Codicons #146

Merged
merged 1 commit into from
Oct 19, 2021
Merged

#406 Update to Theia 1.18.0 and switch to Codicons #146

merged 1 commit into from
Oct 19, 2021

Conversation

ndoschek
Copy link
Contributor

  • Upgrade sprotty version
  • Replace FontAwesome icons with codicons
  • Adapt issue marker svgs to match codicons
  • Adapt workflow example styling
  • Update documentation GIF

Dependes on eclipse-glsp/glsp-server#134

Part of eclipse-glsp/glsp/issues/406

Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

I've just seen two minor issues when tested in combination with the Theia integration (which I've upgraded locally for now). I believe they may be caused by this change in glsp-client even though they only show up in combination with glsp-theia-integration.

  1. When right-clicking a task and select Direct Edit Task and then select duration: and then replace the 0 with anything that's not a number, an error appears. In this error decoration, the icon is now missing.
  2. The forkOrJoin nodes should be black by default and in Theia's light-mode and light gray in dark mode (similar or same as edges in dark mode).

To reproduce, you just need to run yarn upgrade:next in glsp-theia-integration.

@ndoschek
Copy link
Contributor Author

Thank you for your review Philip!
I addressed your comments and force pushed my commit. Also, I opened for the glsp-theia-integration as there were adaptations necessary anyway as well.
If this PR is merged, I will update the glsp-client in the now-draft PR eclipse-glsp/glsp-theia-integration#98

@planger planger self-requested a review October 19, 2021 15:00
@planger
Copy link
Member

planger commented Oct 19, 2021

The forkOrJoin nodes should be black by default and in Theia's light-mode and light gray in dark mode (similar or same as edges in dark mode).

Thanks that's fixed now if I also checkout eclipse-glsp/glsp-theia-integration#98
However now I don't seem to get any error decoration on direct task editing, if I select Direct Edit Task and select duration and replace 0 with an invalid number.
Is this the same for you?

- Upgrade sprotty version
- Replace FontAwesome icons with codicons
- Adapt issue marker svgs to match codicons
- Adapt workflow example styling
- Update documentation GIF
- Add mocha option to ignore style imports (@font-face)

Fixes eclipse-glsp/glsp/issues/406
@ndoschek
Copy link
Contributor Author

Thanks for catching that! As mentioned in the other PR, the reason for that was a missing import of the the css file in the glsp-theia-integration.

Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for your work!

@planger planger merged commit ab8b59c into eclipse-glsp:master Oct 19, 2021
@ndoschek ndoschek deleted the issues/406 branch October 19, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants