Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Theia 1.18.0 and switch to Codicons #406

Closed
6 tasks done
ndoschek opened this issue Oct 6, 2021 · 0 comments
Closed
6 tasks done

Update to Theia 1.18.0 and switch to Codicons #406

ndoschek opened this issue Oct 6, 2021 · 0 comments
Assignees
@ndoschek
Labels
client theia
Projects
GLSP kanban

Comments

@ndoschek
Copy link
Contributor

ndoschek commented Oct 6, 2021 •
edited by tortmayr
Loading

  • Update to Theia 1.18.0
  • With this version, FontAwesome icons were replaced with @vscode/codicons
    • Replace custom/FontAwesome icons with Codicons (e.g. fa fa-project-diagram with codicon codicon-type-hierarchy-sub)
    • Replace FontAwesome CSS classes

Theia offers a ApplicationShellLayoutVersion - should we offer something similiar or reuse and still support FontAwesome icons?
Edit: We agreed on switching completely to codicons, as adopters can still use font-awesome icons if needed.
@martin-fleck-at martin-fleck-at added this to New in GLSP kanban via automation Oct 6, 2021
@planger planger moved this from New to Backlog in GLSP kanban Oct 7, 2021
This was referenced Oct 18, 2021
Merged
Merged
Merged
GLSP kanban automation moved this from Backlog to Done Oct 19, 2021
@ndoschek ndoschek mentioned this issue Oct 19, 2021
Merged
@ndoschek ndoschek reopened this Oct 19, 2021
GLSP kanban automation moved this from Done to New Oct 19, 2021
GLSP kanban automation moved this from New to Done Oct 19, 2021
@ndoschek ndoschek reopened this Oct 19, 2021
GLSP kanban automation moved this from Done to New Oct 19, 2021
@planger planger moved this from New to In progress in GLSP kanban Oct 21, 2021
@ndoschek ndoschek mentioned this issue Oct 21, 2021
Merged
tortmayr added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this issue Oct 27, 2021
@tortmayr
#418#420 Consume server DI rework
f6cf242 
Server
- Update  dependencies to consume latest DI rework
- Update .tpd file and rename it to `r2021-03`
- Adapt existing server code to conform to latest API changes
- Align prefix for eclipse-integration specific classes. (Use `Ide` over `Eclipse`)
- Update  .settings/org.eclipse.jdt.ui.prefs for glsp.ide.editor to ensure that the copyright header for new files has the correct year.
- Introduce a wrapper `GLSPClient` implementation (`IdeGLSPClient`) that handles dedicated GLSPClient proxies for each client session and can be  connected to the `GLSPServer` (#420)
- GLSPDiagramEditor:
-- Refactor Browser-URL generation
-- Generate applicationID and send to client via url query
- Add command to DiagramMenu to open the current DiagramWidget in an external browser for debugging purposes.

Client:
- Update dependencies to latest glsp nightlies
- Adapt code to conform to latest protocol changes
- [WF-Example] Retrieve application id from url params
- [WF-Example] Update webpack config to  webpack 4 and ensure proper source-map generation for debugging
- [WF-Example] Fix webpack build to support codicons (#406)

Fixes eclipse-glsp/glsp/issues/418
Fixes eclipse-glsp/glsp/issues/420
Part of eclipse-glsp/glsp/issues/406
@tortmayr tortmayr mentioned this issue Oct 27, 2021
Merged
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue Nov 1, 2021
@tortmayr
#379#406 Consume protocol-update & DI rework
d4dbcb2 
- Update glsp dependencies  to latest next version
- Remove action definitions that are now provided by @eclipse-glsp/protocol
- Adapt code base to conform to new base protocol
- Update webpack config for codicons (eclipse-glsp/glsp/issues/406)

Fixes eclipse-glsp/glsp/issues/379
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue Nov 1, 2021
@tortmayr
#379#406 Consume protocol-update & DI rework
573c4d2 
- Update glsp dependencies  to latest next version
- Remove action definitions that are now provided by @eclipse-glsp/protocol
- Adapt code base to conform to new base protocol
- Update webpack config for codicons (eclipse-glsp/glsp/issues/406)

Fixes eclipse-glsp/glsp/issues/379
@tortmayr tortmayr mentioned this issue Nov 1, 2021
Merged
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue Nov 1, 2021
@tortmayr
#379#406 Consume protocol-update & DI rework
b304773 
- Update glsp dependencies  to latest next version
- Remove action definitions that are now provided by @eclipse-glsp/protocol
- Adapt code base to conform to new base protocol
- Update webpack config for codicons (eclipse-glsp/glsp/issues/406)

Fixes eclipse-glsp/glsp/issues/379
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue Nov 1, 2021
@tortmayr
#379#406 Consume protocol-update & DI rework
0757d60 
- Update glsp dependencies  to latest next version
- Remove action definitions that are now provided by @eclipse-glsp/protocol
- Adapt code base to conform to new base protocol
- Update webpack config for codicons (eclipse-glsp/glsp/issues/406)

Fixes eclipse-glsp/glsp/issues/379
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue Nov 1, 2021
@tortmayr
#379#406 Consume protocol-update & DI rework
d881752 
- Update glsp dependencies  to latest next version
- Remove action definitions that are now provided by @eclipse-glsp/protocol
- Adapt code base to conform to new base protocol
- Update webpack config for codicons (eclipse-glsp/glsp/issues/406)

Fixes eclipse-glsp/glsp/issues/379
tortmayr added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue Nov 1, 2021
@tortmayr
#379#406 Consume protocol-update & DI rework (#21)
92fdc9d 
- Update glsp dependencies  to latest next version
- Remove action definitions that are now provided by @eclipse-glsp/protocol
- Adapt code base to conform to new base protocol
- Update webpack config for codicons (eclipse-glsp/glsp/issues/406)

Fixes eclipse-glsp/glsp/issues/379
tortmayr added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this issue Nov 5, 2021
@tortmayr
#418#420 Consume server DI rework (#45)
d43f740 
* #418#420 Consume server DI rework

Server
- Update  dependencies to consume latest DI rework
- Update .tpd file and rename it to `r2021-03`
- Adapt existing server code to conform to latest API changes
- Align prefix for eclipse-integration specific classes. (Use `Ide` over `Eclipse`)
- Update  .settings/org.eclipse.jdt.ui.prefs for glsp.ide.editor to ensure that the copyright header for new files has the correct year.
- Introduce a wrapper `GLSPClient` implementation (`IdeGLSPClient`) that handles dedicated GLSPClient proxies for each client session and can be  connected to the `GLSPServer` (#420)
- GLSPDiagramEditor:
-- Refactor Browser-URL generation
-- Generate applicationID and send to client via url query
- Add command to DiagramMenu to open the current DiagramWidget in an external browser for debugging purposes.

Client:
- Update dependencies to latest glsp nightlies
- Adapt code to conform to latest protocol changes
- [WF-Example] Retrieve application id from url params
- [WF-Example] Update webpack config to  webpack 4 and ensure proper source-map generation for debugging
- [WF-Example] Fix webpack build to support codicons (#406)

Fixes eclipse-glsp/glsp/issues/418
Fixes eclipse-glsp/glsp/issues/420
Part of eclipse-glsp/glsp/issues/406
@tortmayr tortmayr closed this as completed Nov 5, 2021
GLSP kanban automation moved this from In progress to Done Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndoschek ndoschek

Labels
client theia
Projects
No open projects
GLSP kanban
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tortmayr @ndoschek