Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure tha DrawFeedbackEdgeAction uses correct type for schema #233

Merged
merged 1 commit into from Mar 10, 2023
Merged

Ensure tha DrawFeedbackEdgeAction uses correct type for schema #233

merged 1 commit into from Mar 10, 2023

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Mar 9, 2023

Follow-up for eclipse-glsp/glsp#926

martin-fleck-at
martin-fleck-at approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tortmayr tortmayr merged commit 5a004c2 into master Mar 10, 2023
@tortmayr tortmayr deleted the fix_s branch May 23, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-fleck-at martin-fleck-at martin-fleck-at approved these changes

@planger planger Awaiting requested review from planger

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tortmayr @martin-fleck-at