Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DrawFeedbackEdgeAction uses SEdge instead of SEdgeSchema #926

Closed
tortmayr opened this issue Feb 20, 2023 · 0 comments · Fixed by eclipse-glsp/glsp-client#230
Closed

DrawFeedbackEdgeAction uses SEdge instead of SEdgeSchema #926

tortmayr opened this issue Feb 20, 2023 · 0 comments · Fixed by eclipse-glsp/glsp-client#230
Assignees
@tortmayr
Labels
bug Something isn't working client
Projects
GLSP kanban

Comments

@tortmayr
Copy link
Contributor

The DrawFeedbackEdge action has a edgeSchema that is used as a template schema to customize the feedback edge.
However, due to an import mixup this property is actually of type SEdge instead of SEdgeSchema.
Also we should allow a partial schema here so that adopters only have to pass the properties that the actually want to change.
@tortmayr tortmayr added bug Something isn't working client labels Feb 20, 2023
@tortmayr tortmayr added this to New in GLSP kanban via automation Feb 20, 2023
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Feb 20, 2023
@tortmayr
Ensure that drawFeedbackAction uses correct schema type
d110db5 
and allow partial schemas
Fixes eclipse-glsp/glsp#926
@tortmayr tortmayr mentioned this issue Feb 20, 2023
Merged
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Feb 21, 2023
@tortmayr
Ensure that drawFeedbackAction uses correct schema type (#230)
40987f7 
and allow partial schemas
Fixes eclipse-glsp/glsp#926
GLSP kanban automation moved this from New to Done Feb 21, 2023
@tortmayr tortmayr self-assigned this Mar 8, 2023
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Mar 9, 2023
@tortmayr
Ensure tha DrawFeedbackEdgeAction uses correct type for schema
2e7cc7f 
Follow-up for  eclipse-glsp/glsp#926
@tortmayr tortmayr mentioned this issue Mar 9, 2023
Merged
tortmayr added a commit to eclipse-glsp/glsp-client that referenced this issue Mar 10, 2023
@tortmayr
Ensure tha DrawFeedbackEdgeAction uses correct type for schema (#233)
5a004c2 
Follow-up for  eclipse-glsp/glsp#926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

Labels
bug Something isn't working client
Projects
No open projects
GLSP kanban
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure that drawFeedbackAction uses correct schema type eclipse-glsp/glsp-client
1 participant
@tortmayr