#418#420 Consume server DI rework #45
Conversation
Server - Update dependencies to consume latest DI rework - Update .tpd file and rename it to `r2021-03` - Adapt existing server code to conform to latest API changes - Align prefix for eclipse-integration specific classes. (Use `Ide` over `Eclipse`) - Update .settings/org.eclipse.jdt.ui.prefs for glsp.ide.editor to ensure that the copyright header for new files has the correct year. - Introduce a wrapper `GLSPClient` implementation (`IdeGLSPClient`) that handles dedicated GLSPClient proxies for each client session and can be connected to the `GLSPServer` (#420) - GLSPDiagramEditor: -- Refactor Browser-URL generation -- Generate applicationID and send to client via url query - Add command to DiagramMenu to open the current DiagramWidget in an external browser for debugging purposes. Client: - Update dependencies to latest glsp nightlies - Adapt code to conform to latest protocol changes - [WF-Example] Retrieve application id from url params - [WF-Example] Update webpack config to webpack 4 and ensure proper source-map generation for debugging - [WF-Example] Fix webpack build to support codicons (#406) Fixes eclipse-glsp/glsp/issues/418 Fixes eclipse-glsp/glsp/issues/420 Part of eclipse-glsp/glsp/issues/406
|
FYI: This PR also improves the debugging experience for frontend code:
|
|
Notes for testing: This PR contains client changes so a client-rebuild is necessary. |
There was a problem hiding this comment.
Thank you very much Tobias for that update! Everything works and looks great! I especially like the Debug in External Browser action and that the browser and the Eclipse IDE are properly synced, that should make our lives much easier :D
I just had one little issue with the yarn.lock you submitted, could you please have a look at it to double-check whether it is not just on my end, thank you!
client/yarn.lock
Outdated
| resolved "https://registry.yarnpkg.com/rc/-/rc-1.2.8.tgz#cd924bf5200a075b83c188cd6b9e211b7fc0d3ed" | ||
| integrity sha512-y3bGgqKj3QBdxLbLkomlohkvsA8gdAiUQlSBJnBhfn+BPxg4bc62d8TcBW15wavDfgexCgccckhcZvywyQYPOw== | ||
| version "1.3.9" | ||
| resolved "https://registry.yarnpkg.com/rc/-/rc-1.3.9.tgz#e59af47fc44a766bbb7c6536df7adce2722e9421" |
There was a problem hiding this comment.
This version is not available for me, instead I need to use 1.2.8:
version "1.2.8"
resolved "https://registry.yarnpkg.com/rc/-/rc-1.2.8.tgz#cd924bf5200a075b83c188cd6b9e211b7fc0d3ed"
integrity sha512-y3bGgqKj3QBdxLbLkomlohkvsA8gdAiUQlSBJnBhfn+BPxg4bc62d8TcBW15wavDfgexCgccckhcZvywyQYPOw==
This can also be easily tested if you just enter https://registry.yarnpkg.com/rc/-/rc-1.3.9.tgz in your browser, it responds with 'Not found'. Could you please double check and push the new yarn.lock if you have the same problem.
| queryParams.put("path", path); | ||
| queryParams.put("port", "" + manager.getLocalPort()); | ||
| queryParams.put("widget", getWidgetId()); | ||
| queryParams.put("application", APPLICATION_ID); |
There was a problem hiding this comment.
Maybe we can have a dedicated protected method to overwrite/add additional parameters without having to override the complete method?
|
@tortmayr Thanks for merging! |
Server
r2021-03IdeoverEclipse)GLSPClientimplementation (IdeGLSPClient) that handles dedicated GLSPClient proxies for each client session and can be connected to theGLSPServer(#420)-- Refactor Browser-URL generation
-- Generate applicationID and send to client via url query
Client:
Fixes eclipse-glsp/glsp/issues/418
Fixes eclipse-glsp/glsp/issues/420
Part of eclipse-glsp/glsp/issues/406