Refactorings regarding source model loading and saving #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planger
force-pushed
the
planger/issues/582
branch
from
2e4cbf8
to
115f047
Compare
tortmayr
requested changes
Mar 25, 2022
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/actions/SaveModelActionHandler.java
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/di/DiagramModule.java
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/di/GModelJsonDiagramModule.java
Show resolved
Hide resolved
...s/org.eclipse.glsp.server/src/org/eclipse/glsp/server/features/core/model/GModelFactory.java
Show resolved
Hide resolved
...eclipse.glsp.server/src/org/eclipse/glsp/server/features/core/model/JsonFileGModelStore.java
Show resolved
Hide resolved
...e.glsp.server/src/org/eclipse/glsp/server/features/core/model/RequestModelActionHandler.java
Show resolved
Hide resolved
....eclipse.glsp.server/src/org/eclipse/glsp/server/features/core/model/SourceModelStorage.java
Show resolved
Hide resolved
....eclipse.glsp.server/src/org/eclipse/glsp/server/features/core/model/SourceModelStorage.java
Outdated
Show resolved
Hide resolved
...eclipse.glsp.server/src/org/eclipse/glsp/server/features/modelsourcewatcher/FileWatcher.java
Show resolved
Hide resolved
....glsp.server/src/org/eclipse/glsp/server/features/modelsourcewatcher/SourceModelWatcher.java
Show resolved
Hide resolved
|
This is the first breaking change since the 0.9.0 so maybe it's also a good idea to update the changelog |
planger
force-pushed
the
planger/issues/582
branch
from
115f047
to
5c60fed
Compare
planger
force-pushed
the
planger/issues/582
branch
from
5c60fed
to
1faaafb
Compare
With this change, I'd like to consistently use the term source model and avoid the term model source. This is to avoid the overlap with Sprotty's concept of ModelSource and its unclear relation to a source model and GModel. I suggest to avoid Model Source altogether and instead introduce and consistently use "source model" to refer to the underlying model that we read and write. Thus we have in GLSP two types of models: * Source Model * Graph Model (GModel) Thus, I did the following refactorings: * Rename ModelSourceLoader to SourceModelPersistence * Add saving to the SourceModelPersistence interface * Delegate from the SaveModelActionHandler to that implementation * Rename ModelSourceWatcher into SourceModelWatcher * Update javadoc and variable names where fit
planger
force-pushed
the
planger/issues/582
branch
from
1faaafb
to
bcd0337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, I'd like to consistently use the term source model and
avoid the term model source. This is to avoid the overlap with Sprotty's
concept of ModelSource and its unclear relation to a source model and
GModel.
I suggest to avoid Model Source altogether and instead introduce and
consistently use "source model" to refer to the underlying model that we
read and write. Thus we have in GLSP two types of models:
Thus, I did the following refactorings:
Fixes eclipse-glsp/glsp#582