Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently apply SourceModelStorage name #655

Closed
tortmayr opened this issue May 20, 2022 · 1 comment
Closed

Consistently apply SourceModelStorage name #655

tortmayr opened this issue May 20, 2022 · 1 comment
Assignees
@planger
Labels
enhancement New feature or request
Projects
GLSP kanban

Comments

@tortmayr
Copy link
Contributor

tortmayr commented May 20, 2022 •
edited
Loading

With eclipse-glsp/glsp-server#154 we introduced a conceptual change and decided to avoid the
term Model Source altogether and instead introduce and
consistently use "source model" to refer to the underlying model that we
read and write.

However, at this point this name change is not consistently applied everywhere. I found the following references to the old model source term:

  • Package name of org.eclipse.glsp.server.features.modelsourcewatcher [Java-Server]
  • ModelSourceChangedAction [server & client/protocol]
  • modelSourceWatcher feature [Client]
  • TheiaModelSourceChangedHandler [theia]
@tortmayr tortmayr added the enhancement New feature or request label May 20, 2022
@tortmayr tortmayr added this to New in GLSP kanban via automation May 20, 2022
@planger planger self-assigned this Jun 1, 2022
planger added a commit to eclipse-glsp/glsp-server that referenced this issue Jun 1, 2022
@planger
Rename ModelSourceChangedAction etc to SourceModelChangedAction
4aac9ee 
This is to be consistent with the term source model that we now use to
refer to the underlying model from which the GModel is created.

eclipse-glsp/glsp#655
@planger planger mentioned this issue Jun 1, 2022
Merged
planger added a commit to eclipse-glsp/glsp-client that referenced this issue Jun 1, 2022
@planger
Rename ModelSourceChangedAction etc.
4300b31 
... to `SourceModelChangedAction`. This is to be consistent with the
term source model that we now use to refer to the underlying model from
which the GModel is created.

eclipse-glsp/glsp#655
@planger planger mentioned this issue Jun 1, 2022
Merged
planger added a commit to eclipse-glsp/glsp-client that referenced this issue Jun 1, 2022
@planger
Rename ModelSourceChangedAction etc.
803c4af 
... to `SourceModelChangedAction`. This is to be consistent with the
term source model that we now use to refer to the underlying model from
which the GModel is created.

eclipse-glsp/glsp#655
planger added a commit to eclipse-glsp/glsp-server that referenced this issue Jun 1, 2022
@planger
Rename ModelSourceChangedAction etc to SourceModelChangedAction
b1d8a6b 
This is to be consistent with the term source model that we now use to
refer to the underlying model from which the GModel is created.

eclipse-glsp/glsp#655
planger added a commit that referenced this issue Jun 1, 2022
@planger
Rename ModelSourceChangedAction
e16a5be 
... to `SourceModelChangedAction`. This is to be consistent with the
term source model that we now use to refer to the underlying model from
which the GModel is created.

#655
@planger planger mentioned this issue Jun 1, 2022
Merged
planger added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Jun 1, 2022
@planger
Rename ModelSourceChangedAction
449c14c 
... to `SourceModelChangedAction`. This is to be consistent with the
term source model that we now use to refer to the underlying model from
which the GModel is created.

eclipse-glsp/glsp#655

Change-Id: Ica2359681f2edb2523aad9d2869d265ad241e381
@planger planger mentioned this issue Jun 1, 2022
Merged
planger added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Jun 1, 2022
@planger
Rename ModelSourceChangedAction
43c398a 
... to `SourceModelChangedAction`. This is to be consistent with the
term source model that we now use to refer to the underlying model from
which the GModel is created.

eclipse-glsp/glsp#655

Change-Id: Ica2359681f2edb2523aad9d2869d265ad241e381
@planger planger moved this from New to In progress in GLSP kanban Jun 1, 2022
@planger planger moved this from In progress to To Review in GLSP kanban Jun 1, 2022
@planger
Copy link
Member

planger commented Jun 1, 2022 •
edited
Loading

planger added a commit to eclipse-glsp/glsp-server-node that referenced this issue Jun 1, 2022
@planger
Rename ModelSourceChangedAction
a8878d1 
... to `SourceModelChangedAction`. This is to be consistent with the term
source model that we now use to refer to the underlying model from which
the GModel is created.

eclipse-glsp/glsp#655
@planger planger mentioned this issue Jun 1, 2022
Merged
tortmayr pushed a commit to eclipse-glsp/glsp-client that referenced this issue Jun 1, 2022
@planger
Rename ModelSourceChangedAction etc. (#184)
c1d28ed 
... to `SourceModelChangedAction`. This is to be consistent with the
term source model that we now use to refer to the underlying model from
which the GModel is created.

eclipse-glsp/glsp#655
tortmayr pushed a commit to eclipse-glsp/glsp-server that referenced this issue Jun 1, 2022
@planger
Rename ModelSourceChangedAction etc to SourceModelChangedAction (#…
6d6903d 
…171)

This is to be consistent with the term source model that we now use to
refer to the underlying model from which the GModel is created.

eclipse-glsp/glsp#655
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Jun 1, 2022
@planger @tortmayr
Rename ModelSourceChangedAction to SourceModelChangedAction (#117)
0374c00 
* Rename `ModelSourceChangedAction`

... to `SourceModelChangedAction`. This is to be consistent with the
term source model that we now use to refer to the underlying model from
which the GModel is created.

eclipse-glsp/glsp#655

Change-Id: Ica2359681f2edb2523aad9d2869d265ad241e381

* Consume latest glsp-client next version

Co-authored-by: Tobias Ortmayr <tortmayr@eclipsesource.com>
tortmayr pushed a commit that referenced this issue Jun 1, 2022
@planger
Rename ModelSourceChangedAction (#669)
a16967e 
... to `SourceModelChangedAction`. This is to be consistent with the
term source model that we now use to refer to the underlying model from
which the GModel is created.

#655
planger added a commit to eclipse-glsp/glsp-server-node that referenced this issue Jun 9, 2022
@planger
Rename ModelSourceChangedAction
5dbd174 
... to `SourceModelChangedAction`. This is to be consistent with the term
source model that we now use to refer to the underlying model from which
the GModel is created.

eclipse-glsp/glsp#655
@tortmayr tortmayr moved this from To Review to Done in GLSP kanban Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@planger planger

Labels
enhancement New feature or request
Projects
No open projects
GLSP kanban
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@planger @tortmayr