Update server.websocket to Jetty 11 #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
force-pushed
the
issues/764
branch
2 times, most recently
from
02737a7
to
f0ad265
Compare
|
Note, in order to use maven locations in the target/tpd files you have to make sure that
|
- Update default target platform
- Eclipse 21.03-> 22.12
- Jetty 9.x -> Jetty 11.0.12
- LSP4J -> 0.8.0 -> 0.19.0
- ELK 0.7.0 -> 0.8.1
- Add slf4j to enable logging in Jetty 10
- Consume log4j,slf4j and javax.servlet via maven
- Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version.
So we instead use the new target platform features and consume it directly from a maven location
- Update server.websocket plugin to conform to Jetty API breaks
- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)
- Provide a second target for 2021-09 to use it as minimal baseline.
Part of eclipse-glsp/glsp#764
Contributed on behalf of STMicroelectronics
planger
approved these changes
Jan 20, 2023
tortmayr
added a commit
that referenced
this pull request
Jan 20, 2023
- Update default target platform
- Eclipse 21.03-> 22.12
- Jetty 9.x -> Jetty 11.0.12
- LSP4J -> 0.8.0 -> 0.19.0
- ELK 0.7.0 -> 0.8.1
- Add slf4j to enable logging in Jetty 10
- Consume log4j,slf4j and javax.servlet via maven
- Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version.
So we instead use the new target platform features and consume it directly from a maven location
- Update server.websocket plugin to conform to Jetty API breaks
- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)
- Provide a second target for 2021-09 to use it as minimal baseline.
Part of eclipse-glsp/glsp#764
Contributed on behalf of STMicroelectronics
tortmayr
added a commit
that referenced
this pull request
Jan 22, 2023
- Update default target platform
- Eclipse 21.03-> 22.12
- Jetty 9.x -> Jetty 11.0.12
- LSP4J -> 0.8.0 -> 0.19.0
- ELK 0.7.0 -> 0.8.1
- Add slf4j to enable logging in Jetty 10
- Consume log4j,slf4j and javax.servlet via maven
- Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version.
So we instead use the new target platform features and consume it directly from a maven location
- Update server.websocket plugin to conform to Jetty API breaks
- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)
- Provide a second target for 2021-09 to use it as minimal baseline.
Part of eclipse-glsp/glsp#764
Contributed on behalf of STMicroelectronics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update default target platform
Consume log4j,slf4j and javax.servlet via maven
Update server.websocket plugin to conform to Jetty API breaks
Update to ELK 0.8.1 and remove workaround (Fixes Remove workaround to force guava version once ELK 0.8.0 is released glsp#265)
Clean up pom files and consistently use properties for all versions
Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)
Provide a second target for 2021-09 to use it as minimal baseline.
Part of eclipse-glsp/glsp#764
Contributed on behalf of STMicroelectronics