Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Jetty to be compatible with Eclipse 2022-09 based product #764

Closed
martin-fleck-at opened this issue Oct 12, 2022 · 2 comments · Fixed by eclipse-glsp/glsp-eclipse-integration#70
Closed

Upgrade Jetty to be compatible with Eclipse 2022-09 based product #764

martin-fleck-at opened this issue Oct 12, 2022 · 2 comments · Fixed by eclipse-glsp/glsp-eclipse-integration#70
Assignees
@tortmayr
Labels
enhancement New feature or request
Projects
GLSP kanban
Milestone
2.0.0 Release

Comments

@martin-fleck-at
Copy link
Contributor

As raised in the discussions the current version of the GLSP IDE editor is no longer compatible with newer Eclipse versions due to their upgrade to Jetty 10. This can be tested by updating the target in the eclipse-integration project to 2022-09.
@martin-fleck-at martin-fleck-at added the enhancement New feature or request label Oct 12, 2022
@N1k145
Copy link

N1k145 commented Oct 12, 2022 •
edited
Loading

If I have seen it correctly also glsp server needs to be updated as the used javax.servlet (used in glsp server websocket) version changed with the jetty version.

@tortmayr tortmayr added this to New in GLSP kanban via automation Nov 14, 2022
@planger planger added help wanted Contributions are very welcome looking for sponsor Please consider sponsoring this feature labels Nov 16, 2022
@planger planger moved this from New to Backlog in GLSP kanban Nov 16, 2022
@planger planger moved this from Backlog to In progress in GLSP kanban Jan 12, 2023
@tortmayr tortmayr added this to the 2.0.0 Release milestone Jan 16, 2023
@tortmayr tortmayr removed help wanted Contributions are very welcome looking for sponsor Please consider sponsoring this feature labels Jan 16, 2023
@tortmayr tortmayr modified the milestones: 2.0.0 Release, Server API Alignment Jan 16, 2023
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Jan 19, 2023
@tortmayr
Update server.websocket to Jetty 10
8c7a23f 
- Update target platform
   - Eclipse 21.03-> 22.12
   - Jetty 9.x -> Jetty 10.0.12
   - LSP4J -> 0.8.0 -> 0.19.0  
   - ELK 0.7.0 -> 0.8.1
   - Add slf4j to enable logging in Jetty 10

- Keep "old" 2021-03 targetplatform and use it as minimal baseline target.

- Consume log4j,slf4j and javax.servlet  via maven
   - Jetty websockt requires slf4j 2.0 which ist not available via orbit and not compatible with the orbit log4j version.
     So we instead use the new target platform features and consume it directly from a maven location

-  Update server.websocket plugin to conform to Jetty API breaks

- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)

Part of eclipse-glsp/glsp#764
@tortmayr
Copy link
Contributor

tortmayr commented Jan 20, 2023 •
edited
Loading

Unfortunately the jetty version provided by the default Eclipse Updatesite does not contain the jetty websocket plugins and is therefore not suitable for our needs. We still have to consume jetty from an external update site (e.g. https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-p2).
After discussing this with the EMF.cloud team I would even opt for updating to Jetty 11. This would allow us to keep the version at least consistent between the EMF.cloud and GLSP projects. Jetty 10 and 11 are feature identical the only difference is that Jetty 10 uses the old javax namespace (javax.websocket, javax.servlet) wheras Jetty 11 uses the new jakarta namespace.

tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Jan 20, 2023
@tortmayr
Update server.websocket to Jetty 11
4b192cf 
- Update default target platform
   - Eclipse 21.03-> 22.12
   - Jetty 9.x -> Jetty 11.0.12
   - LSP4J -> 0.8.0 -> 0.19.0  
   - ELK 0.7.0 -> 0.8.1
   - Add slf4j to enable logging in Jetty 10

- Consume log4j,slf4j and javax.servlet  via maven
   - Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version.
     So we instead use the new target platform features and consume it directly from a maven location

-  Update server.websocket plugin to conform to Jetty API breaks

- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)

- Provide a second target for 2021-09  to use it as minimal baseline.

Part of eclipse-glsp/glsp#764
@tortmayr tortmayr mentioned this issue Jan 20, 2023
Merged
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Jan 20, 2023
@tortmayr
Update server.websocket to Jetty 11
02737a7 
- Update default target platform
   - Eclipse 21.03-> 22.12
   - Jetty 9.x -> Jetty 11.0.12
   - LSP4J -> 0.8.0 -> 0.19.0  
   - ELK 0.7.0 -> 0.8.1
   - Add slf4j to enable logging in Jetty 10

- Consume log4j,slf4j and javax.servlet  via maven
   - Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version.
     So we instead use the new target platform features and consume it directly from a maven location

-  Update server.websocket plugin to conform to Jetty API breaks

- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)

- Provide a second target for 2021-09  to use it as minimal baseline.

Part of eclipse-glsp/glsp#764
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Jan 20, 2023
@tortmayr
Update server.websocket to Jetty 11
f0ad265 
- Update default target platform
   - Eclipse 21.03-> 22.12
   - Jetty 9.x -> Jetty 11.0.12
   - LSP4J -> 0.8.0 -> 0.19.0  
   - ELK 0.7.0 -> 0.8.1
   - Add slf4j to enable logging in Jetty 10

- Consume log4j,slf4j and javax.servlet  via maven
   - Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version.
     So we instead use the new target platform features and consume it directly from a maven location

-  Update server.websocket plugin to conform to Jetty API breaks

- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)

- Provide a second target for 2021-09  to use it as minimal baseline.

Part of eclipse-glsp/glsp#764
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Jan 20, 2023
@tortmayr
Update server.websocket to Jetty 11
afb96c1 
- Update default target platform
   - Eclipse 21.03-> 22.12
   - Jetty 9.x -> Jetty 11.0.12
   - LSP4J -> 0.8.0 -> 0.19.0  
   - ELK 0.7.0 -> 0.8.1
   - Add slf4j to enable logging in Jetty 10

- Consume log4j,slf4j and javax.servlet  via maven
   - Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version.
     So we instead use the new target platform features and consume it directly from a maven location

-  Update server.websocket plugin to conform to Jetty API breaks

- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)

- Provide a second target for 2021-09  to use it as minimal baseline.

Part of eclipse-glsp/glsp#764
Contributed on behalf of STMicroelectronics
@tortmayr tortmayr mentioned this issue Jan 20, 2023
Closed
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Jan 20, 2023
@tortmayr
Update server.websocket to Jetty 11
eb8cdde 
- Update default target platform
   - Eclipse 21.03-> 22.12
   - Jetty 9.x -> Jetty 11.0.12
   - LSP4J -> 0.8.0 -> 0.19.0  
   - ELK 0.7.0 -> 0.8.1
   - Add slf4j to enable logging in Jetty 10

- Consume log4j,slf4j and javax.servlet  via maven
   - Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version.
     So we instead use the new target platform features and consume it directly from a maven location

-  Update server.websocket plugin to conform to Jetty API breaks

- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)

- Provide a second target for 2021-09  to use it as minimal baseline.

Part of eclipse-glsp/glsp#764
Contributed on behalf of STMicroelectronics
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Jan 20, 2023
@tortmayr
Update server.websocket to Jetty 11 (#185)
ddf7ee6 
- Update default target platform
   - Eclipse 21.03-> 22.12
   - Jetty 9.x -> Jetty 11.0.12
   - LSP4J -> 0.8.0 -> 0.19.0  
   - ELK 0.7.0 -> 0.8.1
   - Add slf4j to enable logging in Jetty 10

- Consume log4j,slf4j and javax.servlet  via maven
   - Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version.
     So we instead use the new target platform features and consume it directly from a maven location

-  Update server.websocket plugin to conform to Jetty API breaks

- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)

- Provide a second target for 2021-09  to use it as minimal baseline.

Part of eclipse-glsp/glsp#764
Contributed on behalf of STMicroelectronics
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Jan 20, 2023
@tortmayr
Update server.websocket to Jetty 11 (#185)
b75eade 
- Update default target platform
   - Eclipse 21.03-> 22.12
   - Jetty 9.x -> Jetty 11.0.12
   - LSP4J -> 0.8.0 -> 0.19.0  
   - ELK 0.7.0 -> 0.8.1
   - Add slf4j to enable logging in Jetty 10

- Consume log4j,slf4j and javax.servlet  via maven
   - Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version.
     So we instead use the new target platform features and consume it directly from a maven location

-  Update server.websocket plugin to conform to Jetty API breaks

- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)

- Provide a second target for 2021-09  to use it as minimal baseline.

Part of eclipse-glsp/glsp#764
Contributed on behalf of STMicroelectronics
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Jan 22, 2023
@tortmayr
Update server.websocket to Jetty 11 (#185)
2299c3d 
- Update default target platform
   - Eclipse 21.03-> 22.12
   - Jetty 9.x -> Jetty 11.0.12
   - LSP4J -> 0.8.0 -> 0.19.0  
   - ELK 0.7.0 -> 0.8.1
   - Add slf4j to enable logging in Jetty 10

- Consume log4j,slf4j and javax.servlet  via maven
   - Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version.
     So we instead use the new target platform features and consume it directly from a maven location

-  Update server.websocket plugin to conform to Jetty API breaks

- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)

- Provide a second target for 2021-09  to use it as minimal baseline.

Part of eclipse-glsp/glsp#764
Contributed on behalf of STMicroelectronics
tortmayr added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this issue Jan 23, 2023
@tortmayr
Update to Jetty 10
e782374 
- Consume latest GLSP server version  which uses Jetty 10 and enables support for Eclipse >= 21.09
-  Update to log4j2.
- Provide targets for 2021-09 (minimum baseline) and 22-12 (current(
- Remove keepAliveModule and use infinite session timeout instead

Contributed on behalf of STMIcroelectronics
Fixes eclipse-glsp/glsp#764
@tortmayr tortmayr mentioned this issue Jan 23, 2023
Merged
tortmayr added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this issue Jan 24, 2023
@tortmayr
Update to Jetty 10
5552c9e 
- Consume latest GLSP server version  which uses Jetty 10 and enables support for Eclipse >= 21.09
-  Update to log4j2.
- Provide targets for 2021-09 (minimum baseline) and 22-12 (current(
- Remove keepAliveModule and use infinite session timeout instead

Contributed on behalf of STMIcroelectronics
Fixes eclipse-glsp/glsp#764
tortmayr added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this issue Jan 24, 2023
@tortmayr
Update to Jetty 10 (#70)
56116e3 
- Consume latest GLSP server version  which uses Jetty 10 and enables support for Eclipse >= 21.09
-  Update to log4j2.
- Provide targets for 2021-09 (minimum baseline) and 22-12 (current(
- Remove keepAliveModule and use infinite session timeout instead

Contributed on behalf of STMIcroelectronics
Fixes eclipse-glsp/glsp#764
GLSP kanban automation moved this from In progress to Done Jan 24, 2023
tortmayr added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this issue Jan 24, 2023
@tortmayr
Update to Jetty 10 (#70)
421fa77 
- Consume latest GLSP server version  which uses Jetty 10 and enables support for Eclipse >= 21.09
-  Update to log4j2.
- Provide targets for 2021-09 (minimum baseline) and 22-12 (current(
- Remove keepAliveModule and use infinite session timeout instead

Contributed on behalf of STMIcroelectronics
Fixes eclipse-glsp/glsp#764
tortmayr added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this issue Jan 24, 2023
@tortmayr
Update to Jetty 10 (#70)
857ba83 
- Consume latest GLSP server version  which uses Jetty 10 and enables support for Eclipse >= 21.09
-  Update to log4j2.
- Provide targets for 2021-09 (minimum baseline) and 22-12 (current(
- Remove keepAliveModule and use infinite session timeout instead

Contributed on behalf of STMIcroelectronics
Fixes eclipse-glsp/glsp#764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

Labels
enhancement New feature or request
Projects
No open projects
GLSP kanban
  
Done
Milestone
2.0.0 Release
Development

Successfully merging a pull request may close this issue.

Update to Jetty 10 eclipse-glsp/glsp-eclipse-integration
4 participants
@planger @tortmayr @N1k145 @martin-fleck-at