Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

149: [Websocket] Do not reuse the same Injector for each client connection #91

Merged

Conversation

CamilleLetavernier
Copy link
Member

  • Create a new Injector instance for each client connection, as expected by the GLSP Server infra

fixes eclipse-glsp/glsp/issues/149

- Create a new Injector instance for each client connection, as expected
by the GLSP Server infra

fixes eclipse-glsp/glsp/issues/149

Signed-off-by: Camille Letavernier <cletavernier@eclipsesource.com>
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Thanks

@tortmayr tortmayr merged commit 065c540 into eclipse-glsp:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Websocket Server] Websocket server should not reuse its injector
2 participants