Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#122 #123 Centralize configuration in the server #95

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

planger
Copy link
Member

@planger planger commented Dec 16, 2020

  • Merge ServerConfiguration and DiagramConfiguration
  • Centralize model update protocol in Model Submission Handler

fixes eclipse-glsp/glsp/issues/122
fixes eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier cletavernier@eclipsesource.com

- Merge ServerConfiguration and DiagramConfiguration
- Centralize model update protocol in Model Submission Handler

fixes eclipse-glsp/glsp/issues/122
fixes eclipse-glsp/glsp/issues/123

Signed-off-by: Camille Letavernier <cletavernier@eclipsesource.com>
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tortmayr tortmayr merged commit 2e3da5b into master Dec 16, 2020
@tortmayr tortmayr deleted the planger/issues/122_123 branch December 16, 2020 10:36
dseebacher pushed a commit to dseebacher/glsp-server that referenced this pull request Jan 1, 2021
…-glsp#69)

* eclipse-glsp#95 Cleanup GLSPServerLauncher & add CLI parsing

- Cleanup GLSPServerLauncher (refactor methods & add support to inject additional modules)
- Add a CLIParser helper class and configure default options for configuring
-- Server port
-- consoleLog flag
-- logging directory
-- logLevel
-- help

Fixes eclipse-glsp/glsp/issues/95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Centralize configuration in the server Centralize model update protocol in Model Submission Handler
3 participants