Centralize model loading and GModel creation #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseebacher
pushed a commit
to dseebacher/glsp-server
that referenced
this pull request
Jan 1, 2021
…ommunication (eclipse-glsp#73) * eclipse-glsp#96 eclipse-glsp#94 Cleanup and refactor client-server communication - Refactor client-server communication into a base protocol and a jsonrpc specific implementation (eclipse-glsp#94) - Cleanup protocol and implement (previously unused) shutdown method - Add ClientSessionManager to track lifecycle of GLSP client connections (eclipse-glsp#96) - Add listener-mechanism to react to lifecycle changes (used in DefaultModelStateProvider) - Remove (now obsolete) GLSPClientProxyProvider - Fix wrong version of guava in org.eclipse.glsp.graph pom.xml - Add unique applicationId to InitializeParameters Part of: - eclipse-glsp/glsp/issues/94 - eclipse-glsp/glsp/issues/96 * Fix minors * Adapt copyright headers and fix checkstyle warnings Co-authored-by: Philip Langer <planger@eclipsesource.com>
dseebacher
pushed a commit
to dseebacher/glsp-server
that referenced
this pull request
Jan 1, 2021
) Also: - Use new clientProxy provider instead of deriving the proxy from the client id. - Fix/Surpress a couple of warnings - Sort members of MultiBindingDefaults Follow up for eclipse-glsp/glsp/issues/96
dseebacher
pushed a commit
to dseebacher/glsp-server
that referenced
this pull request
Jan 1, 2021
… session Follow up for eclipse-glsp/glsp/issues/96
tortmayr
requested changes
Jan 4, 2021
...s/org.eclipse.glsp.server/src/org/eclipse/glsp/server/features/core/model/GModelFactory.java
Outdated
Show resolved
Hide resolved
...e.glsp.server/src/org/eclipse/glsp/server/features/core/model/RequestModelActionHandler.java
Outdated
Show resolved
Hide resolved
...e.glsp.server/src/org/eclipse/glsp/server/features/core/model/RequestModelActionHandler.java
Outdated
Show resolved
Hide resolved
|
Thanks @tortmayr, I've updated the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes eclipse-glsp/glsp#119