Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#406 Set Theia keyboard dispatch workspace setting to 'keyCode' #99

Merged
merged 1 commit into from
Oct 21, 2021
Merged

#406 Set Theia keyboard dispatch workspace setting to 'keyCode' #99

merged 1 commit into from
Oct 21, 2021

Conversation

ndoschek
Copy link
Contributor

@ndoschek ndoschek commented Oct 21, 2021

  • This setting ensures, that keypresses are interpreted by the 'keyCode' provided by the OS (e.g. if setting is set to 'code', Ctrl+z would not work if a german layout is used instead of the english one)
  • Fix Theia launch config 'Launch Workflow Browser Frontend'

Part of eclipse-glsp/glsp#406

- This setting ensures, that keypresses are interpreted by the 'keyCode' provided by the OS (e.g. if setting is set to 'code', Ctrl+z would not work if a german layout is used instead of the english one)
- Fix Theia launch config 'Launch Workflow Browser Frontend'
@tortmayr tortmayr self-requested a review October 21, 2021 13:26
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks. 👍

@tortmayr tortmayr merged commit f658c13 into eclipse-glsp:master Oct 21, 2021
@ndoschek ndoschek deleted the issues/406 branch October 21, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants