List<subclass> is currently not allowed in addAll method

[dmm9]

The GModelElementBuilder.addAll() method should accept lists of different types, as long as it extends GModelElement.

i.e. Currently, this fails to compile:

List<GNode> nodeList = new ArrayList<>();
nodeList.add(...);

parent.addAll(nodeList); // error

A good explanation why the Java compiler rejects List<subclass> as argument can be found in this stackoveflow question.

It fixes by changing function signature from:

public E addAll(final List<GModelElement> children)

to

public E addAll(final List<? extends GModelElement> children)

[planger]

Thanks for reporting this issue! This indeed seems like an oversight. Would you be able to open a PR to fix it @dmm9? Thank you!

[dmm9]

yes I am already working on it :)