ModelState for arbitrary semantic model #120
Assignees
Labels
Comments
tortmayr
added a commit
to eclipse-glsp/glsp-server
that referenced
this issue
Oct 19, 2021
With the DI rework #127 its no longer necessary to pass the model state object as part of the execute method. instead action/operation handlers can simply directly inject the model state if the want to use it. Since action & operation handlers are now client session scoped an arbitary state object can be injected and used for execution. (Fixes eclipse-glsp/glsp/issues/120) - Remove the modelstate argument from the execute() method of `ActionHandler` and `OperationHandler` - Remove `Handler` super interface because it doesn't provide any additional value - Add documentation for affected API. - Introduce new `DefaultActionHandler` & `DefaultOperationHandler` that serve as replacement for the now deprecated `BasicActionHandler` & `BasicOperationHandler` - Deprecate `BasicOperationHandler` & `BasicActionHandler`
tortmayr
added a commit
to eclipse-glsp/glsp-server
that referenced
this issue
Oct 19, 2021
With the DI rework #127 its no longer necessary to pass the model state object as part of the execute method. instead action/operation handlers can simply directly inject the model state if the want to use it. Since action & operation handlers are now client session scoped an arbitary state object can be injected and used for execution. (Part of eclipse-glsp/glsp/issues/120) - Remove the modelstate argument from the execute() method of `ActionHandler` and `OperationHandler` - Remove `Handler` super interface because it doesn't provide any additional value - Add documentation for affected API. - Introduce new `DefaultActionHandler` & `DefaultOperationHandler` that serve as replacement for the now deprecated `BasicActionHandler` & `BasicOperationHandler` - Deprecate `BasicOperationHandler` & `BasicActionHandler` & `BasicCreateOperationHandler` - Replace usage of `BasicActionHandler` with `DefaultActionHandler` - Replace usage of `BasicOperationHandler' with `DefaultActionHandler` - Replace usage of `BasicCreateOperationhandler' with `DefaultOperationHandler` & `DefaultCreateOperationHandler` Fixes eclipse-glsp/glsp/issues/425
tortmayr
added a commit
to eclipse-glsp/glsp-server
that referenced
this issue
Oct 25, 2021
With the DI rework #127 its no longer necessary to pass the model state object as part of the execute method. instead action/operation handlers can simply directly inject the model state if the want to use it. Since action & operation handlers are now client session scoped an arbitary state object can be injected and used for execution. (Part of eclipse-glsp/glsp/issues/120) - Remove the modelstate argument from the execute() method of `ActionHandler` and `OperationHandler` - Remove `Handler` super interface because it doesn't provide any additional value - Add documentation for affected API. - Introduce new `DefaultActionHandler` & `DefaultOperationHandler` that serve as replacement for the now deprecated `BasicActionHandler` & `BasicOperationHandler` - Deprecate `BasicOperationHandler` & `BasicActionHandler` & `BasicCreateOperationHandler` - Replace usage of `BasicActionHandler` with `DefaultActionHandler` - Replace usage of `BasicOperationHandler' with `DefaultActionHandler` - Replace usage of `BasicCreateOperationhandler' with `DefaultOperationHandler` & `DefaultCreateOperationHandler` Fixes eclipse-glsp/glsp/issues/425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the modelstate holds a representation of the current gmodel.
In most (advanced) cases we never operate on this GModel directly and its hardly used at all. (mostly just for mapping purposes)
Maybe ModelState should holds arbitrary object (generic type?)
The text was updated successfully, but these errors were encountered: