Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workflow] Editing a task label does not update the name property #1351

Open
tortmayr opened this issue Jun 21, 2024 · 1 comment
Open

[Workflow] Editing a task label does not update the name property #1351

tortmayr opened this issue Jun 21, 2024 · 1 comment
Labels
bug Something isn't working workflow-example

Comments

@tortmayr
Copy link
Contributor

Currently task nodes have a name property, that is intended to reflect the tasks name. However, changing a task name via label edit does only change the text of the label but does not update the property. This causes inconsistencies.

  • We should either drop the name property in the model
  • or introduce a custom ApplyLabelEditHandler that also changes the name in the underlying model.
@tortmayr tortmayr added bug Something isn't working workflow-example labels Jun 21, 2024
tortmayr added a commit to eclipse-glsp/glsp-server-node that referenced this issue Jun 21, 2024
@tortmayr
Fix workflow documentation navigation example
0b849cf 
Update the NodeDocumentationNavigationTargetProvider to not rely on the tasks name which is currently unreliable (see eclipse-glsp/glsp#1351) and instead relies on the `text` property of the tasks label.
@tortmayr tortmayr mentioned this issue Jun 21, 2024
Merged
2 tasks
tortmayr added a commit to eclipse-glsp/glsp-server-node that referenced this issue Jun 21, 2024
@tortmayr
Fix workflow documentation navigation example
b513564 
Update the NodeDocumentationNavigationTargetProvider to not rely on the tasks name which is currently unreliable (see eclipse-glsp/glsp#1351) and instead relies on the `text` property of the tasks label.
tortmayr added a commit to eclipse-glsp/glsp-server-node that referenced this issue Jun 21, 2024
@tortmayr
Fix workflow documentation navigation example (#89)
0fee91e 
Update the NodeDocumentationNavigationTargetProvider to not rely on the tasks name which is currently unreliable (see eclipse-glsp/glsp#1351) and instead relies on the `text` property of the tasks label.
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Jun 24, 2024
@tortmayr
Fix workflow documentation navigation example
7cb49fc 
Update the NodeDocumentationNavigationTargetProvider to not rely on the tasks name which is currently unreliable (see eclipse-glsp/glsp#1351) and instead relies on the `text` property of the tasks label.
@tortmayr tortmayr mentioned this issue Jun 24, 2024
Merged
2 tasks
tortmayr added a commit to eclipse-glsp/glsp-server that referenced this issue Jun 24, 2024
@tortmayr
Fix workflow documentation navigation example (#238)
8f2736e 
Update the NodeDocumentationNavigationTargetProvider to not rely on the tasks name which is currently unreliable (see eclipse-glsp/glsp#1351) and instead relies on the `text` property of the tasks label.
@planger
Copy link
Member

planger commented Jul 11, 2024

I suggest to handle this in combination with #1183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working workflow-example
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@planger @tortmayr