Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial migration guide #1219

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Initial migration guide #1219

merged 5 commits into from
Jan 30, 2024

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Jan 25, 2024

  • Provide first iteration of migration guide (contains migration steps for client and theia-integration)

Contributed on behalf of STMicroelectronics

- Provide first iteration of migration guide (contains migration steps for client and theia-integration)
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tortmayr! Great work on the Migration Guide! I added some notes will migrating a project but I did not finish yet so there might be more to come. I'm just commenting the existing notes to be sure I don't lose them ;-)

MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Show resolved Hide resolved
MIGRATION_GUIDE.md Show resolved Hide resolved
MIGRATION_GUIDE.md Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
@tortmayr
Copy link
Contributor Author

@martin-fleck-at Thanks for the detailled review.
I have pushed a new commit that (hopefully) addresses all your feedback 😉

MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for going through all the iterations with me. I think the guide is really great now, thank you for your great work!

@tortmayr tortmayr merged commit 948f570 into master Jan 30, 2024
5 checks passed
@tortmayr tortmayr deleted the mig-guide branch January 30, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants