Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1625 Use major tag in freebsd ci script #1626

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Sep 12, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Signed-off-by: Christian Eltzschig <me@elchris.org>
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1626 (0e9d021) into master (2c4280e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1626   +/-   ##
=======================================
  Coverage   78.19%   78.20%           
=======================================
  Files         360      360           
  Lines       13862    13862           
  Branches     1942     1942           
=======================================
+ Hits        10840    10841    +1     
  Misses       2418     2418           
+ Partials      604      603    -1     
Flag Coverage Δ
unittests 77.85% <ø> (+<0.01%) ⬆️
unittests_timing 15.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_hoofs/source/concurrent/loffli.cpp 91.42% <0.00%> (+2.85%) ⬆️

@elfenpiff elfenpiff merged commit 6357aa8 into eclipse-iceoryx:master Sep 12, 2022
@elfenpiff elfenpiff deleted the iox-1625-fix-freebsd-ci branch September 12, 2022 12:30
@mossmaurice mossmaurice added the tooling All iceoryx related tooling (scripts etc.) label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FreeBSD CI script is out of data
4 participants