-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #498 remove unreachable code #500
Iox #498 remove unreachable code #500
Conversation
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while it's nice to have something like this, I won't be able to fix anything deepcode is complaining about since it requires a login with my github account and I'm not willing to give them my data
Ok understood, i see this as a proposal for doing some checks on the code. When the deepcode is inconsistent to other tools and some of the developers will not work with it then we maybe should not take it. |
It also depends how the errors are made accessible. If it's possible to access them without a login to their service, then it's a non issue. |
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for giving deepcode.ai a try! While having more and more badges is of course great, we have to make sure developers are not overwhelmed by warning of several tools. From my experience this leads to most developers ignoring the warnings if there are too many and especially accessible on different websites/services. I'd suggest to pick one or two tools and once developers are used to them, we might continue adding more. As discussed in #409 Axivion will be added in the coming months. @dejanpan suggested VectorCast here. This could be a good replacement for codecov in the future, but of course we have to contact Vector regarding licensing beforehand.
Unfortunately not i guess, you need to have an account there which can be created via Github to scan and see the results. |
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
…oryx Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please rename the PR title
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
…s://github.com/ApexAI/iceoryx into iox-eclipse-iceoryx#498-deepcode-ai-on-iceoryx
…oryx Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)Notes for Reviewer
Fix Findings from deepcode.ai
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
Post-review Checklist for the Eclipse Committer
References