Iox #409 axivion analysis on CI

[dkroenke]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Branch follows the naming format (iox-#123-this-is-a-branch)
4. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit messages are signed (git commit -s)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
5. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
6. Relevant issues are linked
7. Add sensible notes for the reviewer
8. All checks have passed (except task-list-completed)
9. Assign PR to reviewer

Notes for Reviewer

This PR brings initial CI tooling for scanning iceoryx with axivion 7.1.3 on GitHub. The current scan happens only on the master branch. After this PR is merged the scan will be triggered. The results are pushed into a dashboard on https://iceoryx-axivion.apex.ai.
Frequent contributors will get access to this dashboard to see the latest scan results on axivion.

More things to come (in progress):

• script for local scan
• scan pull-request branches

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Closes Discussion and meeting on static code analysis #409

[codecov]

Codecov Report

Merging #758 (e0e441a) into master (4ce5310) will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
+ Coverage   74.03%   74.26%   +0.23%     
==========================================
  Files         319      320       +1     
  Lines       11426    11420       -6     
  Branches     1972     1973       +1     
==========================================
+ Hits         8459     8481      +22     
+ Misses       2192     2162      -30     
- Partials      775      777       +2     

Flag	Coverage Δ
unittests	73.08% <ø> (+0.25%)	⬆️
unittests_timing	30.55% <ø> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...e/iceoryx_utils/internal/concurrent/smart_lock.inl	92.45% <0.00%> (-7.55%)	⬇️
..._utils/source/posix_wrapper/unix_domain_socket.cpp	57.07% <0.00%> (-1.83%)	⬇️
iceoryx_posh/source/roudi/process_manager.cpp	61.44% <0.00%> (-0.26%)	⬇️
iceoryx_posh/source/roudi/roudi.cpp	54.28% <0.00%> (ø)
iceoryx_posh/source/mepoo/mepoo_config.cpp	74.19% <0.00%> (ø)
iceoryx_utils/include/iceoryx_utils/cxx/vector.hpp	100.00% <0.00%> (ø)
...ils/include/iceoryx_utils/internal/cxx/smart_c.inl	89.06% <0.00%> (ø)
...e/iceoryx_utils/internal/concurrent/smart_lock.hpp	100.00% <0.00%> (ø)
...clude/iceoryx_utils/internal/cxx/scoped_static.inl	0.00% <0.00%> (ø)
...oryx_utils/source/posix_wrapper/access_control.cpp	56.55% <0.00%> (+0.35%)	⬆️
... and 9 more

[mossmaurice]

LGTM, couple of questions came up

[mossmaurice]

Why are those files specifically listed here?

[mossmaurice]

After having a look at the scan results at https://iceoryx-axivion.apex.ai We shouldn't scan the C binding with the AUTOSAR C++ rules, right? Maybe @neillangmead41 can shed some light on the question, which ruleset to use for C.

[mossmaurice]

LGTM

[mossmaurice]

Why these selection of example here?

[dkroenke]

The examples are the entry point for the Axivion Linker to scan the iceoryx libraries. I put here the iox-roudi for all the roudi-related libraries and examples for pub/sub and waitset for the posh lib. Axivion will then later also cover the unused functionality of the libraries.