-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #409 axivion analysis on CI #758
Iox #409 axivion analysis on CI #758
Conversation
… in private project
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
e1bff4b
to
7956a84
Compare
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
==========================================
+ Coverage 74.03% 74.26% +0.23%
==========================================
Files 319 320 +1
Lines 11426 11420 -6
Branches 1972 1973 +1
==========================================
+ Hits 8459 8481 +22
+ Misses 2192 2162 -30
- Partials 775 777 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couple of questions came up
tools/axivion/axivion_config.json
Outdated
"$(ICEORYX_DIR)/build/install/prefix/bin/iox-cpp-publisher", | ||
"$(ICEORYX_DIR)/build/install/prefix/bin/iox-cpp-subscriber", | ||
"$(ICEORYX_DIR)/build/install/prefix/bin/iox-c-publisher", | ||
"$(ICEORYX_DIR)/build/install/prefix/bin/iox-c-subscriber", | ||
"$(ICEORYX_DIR)/build/install/prefix/bin/iox-cpp-waitset-individual", | ||
"$(ICEORYX_DIR)/build/install/prefix/bin/iox-c-waitset-individual", | ||
"$(ICEORYX_DIR)/build/install/prefix/bin/iox-roudi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are those files specifically listed here?
After having a look at the scan results at https://iceoryx-axivion.apex.ai We shouldn't scan the C binding with the AUTOSAR C++ rules, right? Maybe @neillangmead41 can shed some light on the question, which ruleset to use for C. |
…n scan Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"$(ICEORYX_DIR)/build/install/prefix/bin/iox-cpp-publisher", | ||
"$(ICEORYX_DIR)/build/install/prefix/bin/iox-cpp-subscriber", | ||
"$(ICEORYX_DIR)/build/install/prefix/bin/iox-cpp-waitset-individual", | ||
"$(ICEORYX_DIR)/build/install/prefix/bin/iox-roudi" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these selection of example here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples are the entry point for the Axivion Linker to scan the iceoryx libraries. I put here the iox-roudi for all the roudi-related libraries and examples for pub/sub and waitset for the posh lib. Axivion will then later also cover the unused functionality of the libraries.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
This PR brings initial CI tooling for scanning iceoryx with axivion 7.1.3 on GitHub. The current scan happens only on the master branch. After this PR is merged the scan will be triggered. The results are pushed into a dashboard on https://iceoryx-axivion.apex.ai.
Frequent contributors will get access to this dashboard to see the latest scan results on axivion.
More things to come (in progress):
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References