Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #27 Client Typed API #881

Closed

Conversation

Indra5196
Copy link

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@mossmaurice mossmaurice added the enhancement New feature label Jul 26, 2021
@mossmaurice mossmaurice linked an issue Jul 26, 2021 that may be closed by this pull request
22 tasks
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #881 (db13220) into master (abca825) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #881      +/-   ##
==========================================
- Coverage   74.71%   74.69%   -0.03%     
==========================================
  Files         334      334              
  Lines       12039    12039              
  Branches     2023     2023              
==========================================
- Hits         8995     8992       -3     
- Misses       2262     2263       +1     
- Partials      782      784       +2     
Flag Coverage Δ
unittests 73.59% <ø> (-0.03%) ⬇️
unittests_timing 30.03% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_hoofs/source/concurrent/loffli.cpp 79.41% <0.00%> (-11.77%) ⬇️
iceoryx_posh/source/roudi/process_manager.cpp 60.35% <0.00%> (+0.29%) ⬆️

@elBoberido
Copy link
Member

@Indra5196 just want to check the state of this PR. Initially I did not yet review because there were no tests. Are you waiting for a first review round before adding the tests?

@elBoberido elBoberido mentioned this pull request Oct 28, 2021
20 tasks
@elBoberido
Copy link
Member

Closed in favor of #1089 and #1091

@elBoberido elBoberido closed this Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request/Response communication with iceoryx
3 participants