Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#210] Adjust naming convention and structuree in the remaining files #291

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jul 13, 2024

Notes for Reviewer

This PR adjust the naming and structure for all the FFI files according the last PR

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #210

@elBoberido elBoberido self-assigned this Jul 13, 2024
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.37%. Comparing base (22357f5) to head (e5a4110).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   80.33%   80.37%   +0.04%     
==========================================
  Files         191      191              
  Lines       21814    21814              
==========================================
+ Hits        17524    17533       +9     
+ Misses       4290     4281       -9     

see 5 files with indirect coverage changes

elfenpiff
elfenpiff previously approved these changes Jul 14, 2024
iceoryx2-ffi/ffi/src/node.rs Outdated Show resolved Hide resolved
iceoryx2-ffi/ffi/src/node_builder.rs Outdated Show resolved Hide resolved
@elBoberido elBoberido force-pushed the iox2-210-adjust-naming-convention-for-c-binding branch 3 times, most recently from 8a412ce to e4cb9f7 Compare July 14, 2024 13:01
@elBoberido elBoberido force-pushed the iox2-210-adjust-naming-convention-for-c-binding branch from e4cb9f7 to e5a4110 Compare July 14, 2024 14:01
@elBoberido elBoberido merged commit 036de1e into eclipse-iceoryx:main Jul 15, 2024
53 checks passed
@elBoberido elBoberido deleted the iox2-210-adjust-naming-convention-for-c-binding branch July 15, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants